Add blockGap support to paragraph block

[bradhogan]

It would be useful to be able to overwrite the main gap value for a site within the paragraph block. For example, if I don't want my gap between paragraphs to be the same as the gap between columns, then I should be able to control that. If defined in the theme.json, it would look like:

"core/paragraph": {
  "spacing": {
	  "blockGap": "1.5rem"
  }
}

Here's a related issue and the above request would resolve this.

[t-hamano]

Hi @bradley2083,
Could your problem be solved by wrapping multiple blocks in a group block?
I think the block gap is only for adjusting the spacing of multiple elements within a single block. And I believe there are no multiple elements in a paragraph block, but simply a line break.

430cb04e1878c1dc9976048049e17ed0.mp4

Or, if you want to adjust the default space between paragraphs, margin should work instead of blockGap.

[bradhogan]

Manually adjusting spacing or wrapping paragraphs in a group block would be too cumbersome. It would be much easier to either remove the default gap spacing entirely from the paragraph block so that global spacing was set with margin (or padding) OR add a blockGap option to the paragraph block (what I think makes the most sense since a few other blocks already have this option).

…

On Sat, Sep 17, 2022 at 9:00 AM Aki Hamano ***@***.***> wrote: Hi @bradley2083 <https://github.com/bradley2083>, Could your problem be solved by wrapping multiple blocks in a group block? I think the block gap is only for adjusting the spacing of multiple elements within a single block. And I believe there are no multiple elements in a paragraph block, but simply a line break. https://user-images.githubusercontent.com/54422211/190863279-821a8b1f-8c87-48ea-ac37-d084e2128d85.mp4 Or, if you want to adjust the default space between paragraphs, margin should work instead of blockGap. [image: margin] <https://user-images.githubusercontent.com/54422211/190863378-bd604a9e-0271-496d-affa-dd5d2bd1c367.png> — Reply to this email directly, view it on GitHub <#44232 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANS32TOVVLJLJC2KYT2NRDV6XMJTANCNFSM6AAAAAAQOPWW4I> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[t-hamano]

The blockGap supported by a block is only to adjust the margins between elements within that block.
It should not control the margins with other blocks.
If you want to define margins between blocks, including paragraphs, you can define styles.spacing.blockGap.

{
	"styles": {
		"spacing": {
			"blockGap": "30px"
		}
	}
}

[bradhogan]

I understand we can set the global option for blockGap in styles, but that sets the blockGap for ALL blocks. I'm suggesting a very practical addition of adding blockGap support for the paragraph block. There are many instances in a design where a theme dev might want to have the default blockGap set to something much larger than what they would want the paragraph spacing to be.

[t-hamano]

I understand.
However, I think it should be called "margin", not "blockGap".
Furthermore, I believe your intent was to specify a specific margin based on the combination of the current block and the next block.

Then, for example, the following approach might make sense:

"core/paragraph": {
	"spacing": {
		"nextBlockMargin":  [
			// Margin between paragraphs
			{
				"nextBlocks": [ 'core/paragraph'],
				"margin": "1em"
			},
			// Margin between paragraph and heading
			{
				"nextBlocks": [ 'core/heading'],
				"margin": "2em"
			}
		]
	}
}

[jordesign]

This is in many ways similar to #51255

I'd agree with the comments above that this isn't a Block Gap issue - but more to do with having the margin overide any block gap