Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spacer block in 12.3.0 fails #37758

Closed
evaldivieso opened this issue Jan 6, 2022 · 4 comments · Fixed by #37774
Closed

Adding spacer block in 12.3.0 fails #37758

evaldivieso opened this issue Jan 6, 2022 · 4 comments · Fixed by #37774
Assignees
Labels
[Block] Spacer Affects the Spacer Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@evaldivieso
Copy link

evaldivieso commented Jan 6, 2022

Description

Seems like the latest updates to the spacer block is causing a bug, after I applied the latest Gutenberg plugin updates (12.3.0) this week I started to see the below message after insert the spacer block:

This block has encountered an error and cannot be previewed.

This just started happening this week, last week I've been using the spacer block fine.

Screenshots, screen recording

SS 2022-01-06 at 12 30 21 PM

2022-01-06.12-51-31.mp4

TypeError: (0,Oe.useSetting)("spacing.units").filter is not a function. (In '(0,Oe.useSetting)("spacing.units").filter((e=>"%"!==e))', '(0,Oe.useSetting)("spacing.units").filter' is undefined)

The above error occurred in the <Ah> component:

I also tried uninstalling the Gutenberg 12.3.0 plugin and installing the Gutenberg 12.2.0 and the spacer was working fine, I then updated to latest 12.3.0 version and run into the same issue.

Can someone please confirm and provide info for this issue. Thanks

@annezazu
Copy link
Contributor

annezazu commented Jan 7, 2022

Thanks for reporting @evaldivieso ! How strange. I was able to replicate but only with certain themes.

  • Spacer block works with Twenty Twenty-Two, Twenty Twenty-One,
  • Spacer block doesn't work with Twenty Nineteen, Twenty Twenty, Twenty Seventeen.

Adding this as a regression to be looked into further. The above was confirmed with 5.9 RC1 as well so adding to the 5.9 board.

@annezazu annezazu added [Block] Spacer Affects the Spacer Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Jan 7, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Jan 7, 2022

I think the issue was introduced by #36186.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 7, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Jan 7, 2022

@annezazu, I'm not able to reproduce the issue with 5.9 RC1 if I disable the Gutenberg plugin.

@annezazu
Copy link
Contributor

annezazu commented Jan 7, 2022

Tried on a fresh install (that never had GB installed) with RC1 and can see it works fine with 5.9 RC1 :) Have another test site that can replicate but seems to be isolated. Removing from 5.9 must haves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Spacer Affects the Spacer Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants