Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple themes: Spacer block crashes #59846

Closed
arunsathiya opened this issue Jan 7, 2022 · 44 comments
Closed

Multiple themes: Spacer block crashes #59846

arunsathiya opened this issue Jan 7, 2022 · 44 comments
Labels
[Pri] High [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@arunsathiya
Copy link
Contributor

arunsathiya commented Jan 7, 2022

Quick summary

The "Spacer" block crashes on adding to a page or post with Hemingway Rewritten theme.

Steps to reproduce

  • Start with a WordPress.com site.
  • Activate Hemingway Rewritten theme on it.
  • Create a page or a post.
  • Add a "Spacer" block.
  • See that it crashes on adding to the page/post.

What you expected to happen

The block does not crash.

What actually happened

The block crashes.

image

The console reads:

TypeError: Oe.useSetting(...).filter is not a function

Context

Customer report: 4666985-zen.

Simple, Atomic or both?

Simple

Theme-specific issue?

Hemingway Rewritten

Browser, operating system and other notes

  • All browsers, OS.
  • This happens only on Simple, not on Atomic.

Reproducibility

Consistent

Severity

Most (> 50%)

Available workarounds?

No and the platform is unusable

Workaround details

No response

@arunsathiya arunsathiya added [Type] Bug User Report This issue was created following a WordPress customer report labels Jan 7, 2022
@marutim
Copy link

marutim commented Jan 7, 2022

I can replicate the same issue with Dara theme.

image

@samvaidya
Copy link

Another user reporting this issue on the Hive theme (retired).

Follow-up ticket: 4668513-zen

@hacchism
Copy link

hacchism commented Jan 7, 2022

Another user reporting this on the Gateway theme.

Follow-up ticket: 4669094-zen

Also, I've set this as a High priority considering the impact on users(Followed the chart in p7DVsv-d1T-p2)

@edwinho89
Copy link

33345583-hc . User is on AT site, and using Apostrophe 2 theme.

I'm able to reproduce this on my test AT site, using Storefront theme as well.

Deactivating Gutenberg (currently v12.3.0) plugin on both AT site does fix the issue.

@arunsathiya arunsathiya changed the title Hemingway Rewritten: Spacer block crashes Multiple themes: Spacer block crashes Jan 8, 2022
@sarahcada
Copy link

Listing reports from #59855:

28311339-hc: Libretto theme. Simple site only.
335393000-hc: 3rd-party theme, and on a test Atomic site (retired Patch theme), reported by @thekingsprojects
32466914-hc: Ixion, reported by @allanftd

@sarahcada
Copy link

A couple more reports:
4669149-zd-woothemes: Corporate (retired) theme
4669612-zd-woothemes: Suits (retired) theme

@filipanoscampos
Copy link

Another report here: 4660627-zd-woothemes.
The user is using a retired Premium theme, Photographer.

@mrsjaved
Copy link

mrsjaved commented Jan 8, 2022

Another report here:
4669949-zd-woothemes

Using Plane theme.

@susanjanec
Copy link

Another report in 4666823-zd-woothemes

Using Twenty Fifteen theme

@synora
Copy link
Contributor

synora commented Jan 8, 2022

Another Atomic site report: 4670442-zd-woothemes
Using the Bloggy(retired theme)

@nickpagz
Copy link

nickpagz commented Jan 8, 2022

Simple site, Rebalance theme. 4670402-zen

@suyogyashukla
Copy link
Member

suyogyashukla commented Jan 8, 2022

Another report in 4670108-zen, multiple sites. Themes: Redhill and Gateway and Shoreditch.

@masperber
Copy link

33549426-hc. AT site, Radcliffe 2 theme

@khristiansnyder
Copy link

#33553316-hc
At
Twenty Fourteen

@syedshaon
Copy link

#4671099-hc
Nikau Theme

@retnonindya
Copy link

4667552-zd-woothemes
Theme Beacon (retired Premium theme)

@syedshaon
Copy link

syedshaon commented Jan 9, 2022

#4671247-zen
Theme: Attache

@dolgelukkig
Copy link

dolgelukkig commented Jan 9, 2022

Simple site
4666321-zen
Theme: Twenty Twenty-One

@wprhunt
Copy link

wprhunt commented Jan 9, 2022

Simple site
4672889-zen
Theme: Apostrophe2

@KirkwallDay
Copy link

Another instance here: 33565797-hc
Atomic
Theme: Twenty Seventeen

@jerrysarcastic
Copy link

@jordesign
Copy link
Contributor

Also reported in 4672183-zd-woothemes
Simple site - Canard theme

@kathrynwp
Copy link
Member

Another report in 4673087-zen

Simple site, Moka theme

@kathrynwp
Copy link
Member

kathrynwp commented Jan 9, 2022

Another report in 33260326-hc
TwentySixteen theme - Simple site

@NoHopeRadio - moved here from #59855 since that was closed as a dupe!

@ramonjd
Copy link
Member

ramonjd commented Jan 9, 2022

Hmm, it looks like this PR will address the issue based on the reported JS error:

WordPress/gutenberg#37774

@jordesign
Copy link
Contributor

Thanks @ramonjd - just noting the Gutenberg Issue for our reference to track as well.
WordPress/gutenberg#37758

@thebud15
Copy link

Came up in #33569153-hc
Simple site
Theme: Radcliffe 2

@formosattic
Copy link

+1 26384477-hc
Simple site
Theme (retired): Romero

@inaikem
Copy link
Contributor

inaikem commented Jan 10, 2022

User report in 4674003-zen (Twenty Thirteen).

Confirmed as affecting the following themes:

  • Twenty Eleven
  • Twenty Twelve
  • Twenty Thirteen
  • Twenty Fourteen
  • Twenty Fifteen
  • Twenty Sixteen
  • Twenty Seventeen
  • Twenty Nineteen
  • Twenty Twenty

I reported in #59896 before being pointed here.

@NatzJoy
Copy link

NatzJoy commented Jan 10, 2022

Another report in 33575341-hc

Atomic site using the Stratford theme.

@kingsleyinfo
Copy link
Collaborator

I just came across this bug and was able to replicate it on my own site. However, adding the Spacer block when the block settings toolbar is not toggled does not throw an error
Recording here:

Screen.Capture.on.2022-01-10.at.12-40-59.mp4

+1 33316541-hc

@dragstor
Copy link
Member

Reported by the user from 33402750-HC as well.

I suggested the workaround by @kingsleyinfo :)

@ccwalburn
Copy link

ccwalburn commented Jan 10, 2022

Another report here 33578535-hc
Deactivating Gutenberg fixed it for this user.
Atomic Site using Baskerville 2 child theme

@rachelwinspear
Copy link

Simple site: 27630439-hc
Theme: Hive - Retired.

@nickpagz
Copy link

Atomic, dyad 2 child theme. 33497028-hc

@cuemarie
Copy link

Simple site: 30043802-hc
Theme: Nikau (Retired)

@jackiejade
Copy link

Another: 32613955-hc
Theme: Twenty Sixteen

@maciejpilarski
Copy link

Another: 4674255-zd
Theme: ZoxPress

@fullofcaffeine
Copy link
Contributor

fullofcaffeine commented Jan 11, 2022

This should be fixed in Gutenberg 12.3.2, which has just been released on WPCOM.

@inaikem
Copy link
Contributor

inaikem commented Jan 11, 2022

Thanks @fullofcaffeine.

Cc @Automattic/dotcom-pa-group to start the bulk reply process 🙏

@inaikem
Copy link
Contributor

inaikem commented Jan 11, 2022

Via @formosattic: 4676893-zd-woothemes

@Thelmachido
Copy link

Another report here: 33598836 -hc

@edwinho89
Copy link

4673091-zd-woothemes

@Greatdane
Copy link

Hi everyone 👋 Just a quick note to let you all know @Automattic/dotcom-triage-pa-group have finished following up with affected users reported in this thread.

Thanks for the reports, please let us know here if you see any future recurrence of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests