-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme.json styles are not loaded when previewing a FSE theme in the Customizer #34531
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Comments
youknowriad
added
[Priority] High
Used to indicate top priority items that need quick attention
[Type] Bug
An existing feature does not function as intended
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Sep 3, 2021
Hey, I can repro. Some info:
So, the global stylesheet is loaded fine in some situations. It appears to be somehow blocked for block-based themes in the customizer. |
youknowriad
removed
the
[Priority] High
Used to indicate top priority items that need quick attention
label
Sep 3, 2021
github-actions
bot
added
the
[Status] In Progress
Tracking issues with work in progress
label
Sep 3, 2021
I've got a fix at #34540 |
Meta trac ticket that may be related https://meta.trac.wordpress.org/ticket/5818#comment:4 (previews for themes with theme.json not working consistently in the theme directory) |
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this issue
Sep 16, 2021
Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory). This commit makes sure the stylesheet is regenerated upon switching themes. Props oandregal, dd32. See #53175. git-svn-id: https://develop.svn.wordpress.org/trunk@51819 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this issue
Sep 16, 2021
Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory). This commit makes sure the stylesheet is regenerated upon switching themes. Props oandregal, dd32. See #53175. git-svn-id: https://develop.svn.wordpress.org/trunk@51819 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this issue
Sep 16, 2021
Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory). This commit makes sure the stylesheet is regenerated upon switching themes. Props oandregal, dd32. See #53175. Built from https://develop.svn.wordpress.org/trunk@51819 git-svn-id: http://core.svn.wordpress.org/trunk@51426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this issue
Sep 16, 2021
Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory). This commit makes sure the stylesheet is regenerated upon switching themes. Props oandregal, dd32. See #53175. Built from https://develop.svn.wordpress.org/trunk@51819 git-svn-id: https://core.svn.wordpress.org/trunk@51426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
danfarrow
pushed a commit
to danfarrow/wordpress-develop
that referenced
this issue
Sep 30, 2021
Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory). This commit makes sure the stylesheet is regenerated upon switching themes. Props oandregal, dd32. See #53175. git-svn-id: https://develop.svn.wordpress.org/trunk@51819 602fd350-edb4-49c9-b593-d223f7449a82
danielpunkass
pushed a commit
to danielpunkass/wordpress-develop
that referenced
this issue
Oct 26, 2021
Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory). This commit makes sure the stylesheet is regenerated upon switching themes. Props oandregal, dd32. See #53175. git-svn-id: https://develop.svn.wordpress.org/trunk@51819 602fd350-edb4-49c9-b593-d223f7449a82
doiftrue
pushed a commit
to doiftrue/wordpress-develop
that referenced
this issue
Oct 30, 2021
Global styles are used in a few different contexts (front, editor, customizer, the theme directory). In the last two contexts, it's important that switching themes immediately refreshes the global stylesheet, to avoid situations in which the styles of the previous theme load with the new one. This was brought up at WordPress/gutenberg#34531 (customizer) and at meta.trac.wordpress.org/ticket/5818 (theme directory). This commit makes sure the stylesheet is regenerated upon switching themes. Props oandregal, dd32. See #53175. git-svn-id: https://develop.svn.wordpress.org/trunk@51819 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Description
If you have a non-FSE theme active, go to the Customizer, click the "Change" button next to the name of the active theme, and select a FSE theme to preview, the preview that gets loaded doesn't include any of the theme.json styles in the theme.
The preview does work if you have a FSE theme active (like Blockbase) and preview a different FSE theme (like TT1 Blocks), but not if your active theme is a non-FSE theme.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Environment info
WordPress 5.8, Gutenberg 11.4.0
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: