-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to highlight blocks that are wrapped by another block. #33
Comments
Fixing this can quickly lead into z-index hell 😉 |
@jasmussen had some thoughts on this. Seems just bumping z-index for floated content would be fine :) |
They can then overlap controls of another element due to the higher z-index. So we will want to probably have all controls at a z-index of 3, and any "floated" content have a z-index of 2 for now. |
Copying from Slack:
Can you elaborate? You'll only ever see the block outlines and formatting controls of any one selected block at any one time, in this prototype. |
Yes, so if you have the controls of the element that is not z-indexed higher active, ( inline controls, adding a new block controls, etc. ) potentially the "floated" content with a higher z-index covers it. Just came across it, while goofing around with the editor and fixing the z-index. Controls quickly became covered by the new higher priority z-index block. |
Basically, controls should always be on top so they are not hidden, and "floated" blocks should appear at a higher z-index than normal flow blocks. |
Add test for making sure `addQueryArgs` updates existing arguments.
…nism iOS: Improves the text view automatic sizing mechanism.
Update `rule-nested-empty-line-before` rule with option `ignore: ["after-comment"]`.
If enough wrapped text is added around an image block, it becomes no longer possible to access the images block level controls. Adding z-index to the image when in "left-aligned" or "right-aligned" will most likely alleviate that problem.
The text was updated successfully, but these errors were encountered: