Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to highlight blocks that are wrapped by another block. #33

Closed
BE-Webdesign opened this issue Feb 9, 2017 · 6 comments
Closed
Labels
[Type] Question Questions about the design or development of the editor.

Comments

@BE-Webdesign
Copy link
Contributor

If enough wrapped text is added around an image block, it becomes no longer possible to access the images block level controls. Adding z-index to the image when in "left-aligned" or "right-aligned" will most likely alleviate that problem.

@BE-Webdesign
Copy link
Contributor Author

BE-Webdesign commented Feb 9, 2017

Fixing this can quickly lead into z-index hell 😉

@mtias
Copy link
Member

mtias commented Feb 9, 2017

@jasmussen had some thoughts on this. Seems just bumping z-index for floated content would be fine :)

@mtias mtias added [Type] Question Questions about the design or development of the editor. UI Prototype labels Feb 9, 2017
@BE-Webdesign
Copy link
Contributor Author

They can then overlap controls of another element due to the higher z-index. So we will want to probably have all controls at a z-index of 3, and any "floated" content have a z-index of 2 for now.

@jasmussen
Copy link
Contributor

@jasmussen had some thoughts on this. Seems just bumping z-index for floated content would be fine :)

Copying from Slack:

this would probably work pretty well if we could z-index the image on top, and perhaps add a white border so it "cuts through" the paragraph block border

@BE-Webdesign:

They can then overlap controls of another element due to the higher z-index. So we will want to probably have all controls at a z-index of 3, and any "floated" content have a z-index of 2 for now.

Can you elaborate? You'll only ever see the block outlines and formatting controls of any one selected block at any one time, in this prototype.

@BE-Webdesign
Copy link
Contributor Author

@jasmussen

You'll only ever see the block outlines and formatting controls of any one selected block at any one time, in this prototype.

Yes, so if you have the controls of the element that is not z-indexed higher active, ( inline controls, adding a new block controls, etc. ) potentially the "floated" content with a higher z-index covers it. Just came across it, while goofing around with the editor and fixing the z-index. Controls quickly became covered by the new higher priority z-index block.

@BE-Webdesign
Copy link
Contributor Author

Basically, controls should always be on top so they are not hidden, and "floated" blocks should appear at a higher z-index than normal flow blocks.

omarreiss added a commit that referenced this issue Jun 26, 2018
Add test for making sure `addQueryArgs` updates existing arguments.
hypest pushed a commit that referenced this issue Nov 2, 2018
…nism

iOS: Improves the text view automatic sizing mechanism.
ntwb added a commit that referenced this issue May 31, 2020
Update `rule-nested-empty-line-before` rule with option `ignore: ["after-comment"]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

3 participants