Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish design of Button block, and redesign link input #3283

Closed
jasmussen opened this issue Nov 1, 2017 · 4 comments · Fixed by #3427
Closed

Polish design of Button block, and redesign link input #3283

jasmussen opened this issue Nov 1, 2017 · 4 comments · Fixed by #3427
Labels
[Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback.

Comments

@jasmussen
Copy link
Contributor

Issue Overview

The Button block could use a bit of love given recent Gutenberg changes. Here's what it looks like now:

screen shot 2017-11-01 at 08 46 35

The Blue is a Gutenberg blue, not one from the theme. The link toolbar covers content, both the block itself and succeeding content. Given how cool this block can be, let's look at some polish.

Mockups

Unselected:

button

It shows a "Button" label. It also uses the same font and font-size as body text, making the appearance simpler. It defaults to currentColor as the background, with white text on top of it, which further reduces the visual footprint. Remember, you can still change colors in the inspector.

Selected

If we lean into the principles we laid out in the design doc, we can show controls on a selected block after the block itself. Just like how the caption field makes the Image block take up more vertical space when selected, so, perhaps, can we do with the button block:

button selected

In this design, a minimal link input field sits below the button, ready to be pasted into. It's no longer a toolbar (even if it is the same component), so it doesn't cover anything.

Thoughts?

CC: @karmatosed

@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks Design Needs Design Feedback Needs general design feedback. labels Nov 1, 2017
@rileybrook
Copy link

rileybrook commented Nov 1, 2017

we can show controls on a selected block after the block itself.

In this design, a minimal link input field sits below the button, ready to be pasted into. It's no longer a toolbar (even if it is the same component), so it doesn't cover anything.

This makes the link experience feel very intuitive. This idea looks really thoughtful, and feels like a step in the right direction.

@hedgefield
Copy link

Really great. I was just thinking of this concept for the permalink, glad to see you had the same approach here. 👌

@afercia
Copy link
Contributor

afercia commented Nov 6, 2017

a minimal link input field sits below the button

Just a quick reminder: any input field or editable element needs to be properly labeled (at least with an aria-label attribute). Placeholders are not replacements for labels.

@karmatosed
Copy link
Member

I really like this. Can we roll it out on the cover image block when the button is added too?

jasmussen pushed a commit that referenced this issue Nov 10, 2017
This fixes #3283.

This is a redesign of the button block to be more neutral looking. In addition to this, it makes the URL aspect inline, so it behaves just like how a caption does on an image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants