Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing flow: Horizontal arrow navigation doesn't work on non-text inputs #32715

Closed
mirka opened this issue Jun 15, 2021 · 0 comments · Fixed by #41538
Closed

Writing flow: Horizontal arrow navigation doesn't work on non-text inputs #32715

mirka opened this issue Jun 15, 2021 · 0 comments · Fixed by #41538
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] In Progress Tracking issues with work in progress

Comments

@mirka
Copy link
Member

mirka commented Jun 15, 2021

Related #32712 #32713

Description

Writing flow navigation with the left/right keys does not work with non-text input elements, such as checkbox and button.

return tagName !== 'INPUT' && tagName !== 'TEXTAREA';

Step-by-step reproduction instructions

  1. Add some <input type="button" /> to the edit component of a Core block, such as Code. If necessary, flexbox the container so the buttons are horizontally aligned.
  2. Move keyboard focus to the first button, and hit the right arrow key.

Expected behaviour

The keyboard focus moves to the second button.

Actual behaviour

Nothing happens, and I cannot move the focus to the next button.

Screenshots or screen recording (optional)

Cannot navigate horizontally by keyboard

WordPress information

Latest trunk in wp-env container.

Device information

  • Device: Desktop
  • Operating system: macOS 11.3
  • Browser: Chrome 91.0.4472.77
@Mamaduka Mamaduka added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Jun 16, 2021
@mirka mirka self-assigned this Jun 3, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants