Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing flow: Select all doesn't work when focused on a non-text input #32713

Closed
mirka opened this issue Jun 15, 2021 · 1 comment
Closed

Writing flow: Select all doesn't work when focused on a non-text input #32713

mirka opened this issue Jun 15, 2021 · 1 comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...

Comments

@mirka
Copy link
Member

mirka commented Jun 15, 2021

Description

"Select all" doesn't select all blocks when focused on an input element type that doesn't support selection ranges, such as checkbox.

Step-by-step reproduction instructions

  1. Add a <input type="checkbox" /> to the edit component of a Core block, such as Code.
  2. Move keyboard focus to the checkbox.
  3. Do a "Select all" (e.g. ⌘A).

Expected behaviour

All blocks are selected, as if I were focused on any other non-text tabbable element like <button>.

Actual behaviour

All the text in the window is selected.

Screenshots or screen recording (optional)

Select all does not work as expected when focused on a checkbox

WordPress information

Latest trunk in wp-env container.

Device information

  • Device: Desktop
  • Operating system: macOS 11.3
  • Browser: Chrome 91.0.4472.77

Intelligent support for this behavior would require a more advanced system to classify input elements, because some types do have built-in Select All behavior (e.g. number) but don't support selection range attributes.

@Mamaduka Mamaduka added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Jun 16, 2021
@ellatrix ellatrix added the [Feature] Block Multi Selection The ability to select and manipulate multiple blocks label Aug 16, 2023
@jordesign
Copy link
Contributor

It seems this should have been closed by the issues mentioned above - and I can no longer recreate this so i'll close it for now.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

No branches or pull requests

4 participants