Improvements to Site Logo block

[mtias]

The site logo is currently quite rough. This is a list of improvements to make.

• Add alignments control. [Block Library - Site Logo]: Fix supports declaration #31544
• Add inline cropping. Add site logo crop #31607
• Better icon. Icons: Update site-logo block icon. #30211
• Add link toggle to "home".
• Set a default width of around 120px. Currently the block displays huge and doesn't seem like a logo at all. Polish the Site Logo block. #30526
• Update the placeholder to also be simpler and look like a smaller target for drag and drop instead of the wide default placeholder. Polish the Site Logo block. #30526
• Allow using the site logo for the site icon from the block inspector — this is an important flow. Site Logo: Add option to set site icon from Site Logo block #35892
• Expand block description to explain what it is and how it works better. Polish the Site Logo block. #30526
• Improve block description.
• Site Logo: update placeholder to wireframe #35096
• Allow clearing / removing the media. #34796
• Site Logo Block: Support the duotone feature #34146

[jasmussen]

Nice one, I'm going to take a stab at a few of these. Though note, when the site logo is used in the right context — in my case the site editor, I'm seeing the alignments control correctly show up:

I'm not sure why they don't show up when used in the post editor, @scruffian do you recall?

[jasmussen]

CC: @ajlende, I know you have your plate full, but wanted to point to the cropping task in case it's an easy one.

[JustinyAhin]

Just jumping on those
I'd like to tackle the width issue

[jasmussen]

@JustinyAhin I've fixed the width issue in a PR I'm currently making 🙈

[JustinyAhin]

Oh good to know @jasmussen .
Moving to my usual triage then 😀

[jasmussen]

The Site Logo shows up even if my theme has not declared support using add_theme_support. This is probably good, but it did surface a few issues:

• Once I define a site logo and publish it, I cannot unset it just from the block.

I ended up having to switch to a theme that did support custom logos, then removing it in the customizer.

[jameskoster]

Allow using the site logo for the site icon from the block inspector — this is an important flow.

I think it should be possible for users to do this elsewhere as well. I shouldn't have to be displaying my Site Logo in order to set the Site Icon. In fact I ran in to this exact use case when helping a friend with their site over the weekend. They wanted to set a favicon, but also wanted a plain text "logo" in their site header.

Likewise I shouldn't have to go in and edit a template to update my logo. This should be possible of course, but not the only way.

I would vote for adding these to the WP settings alongside the Site Title and Tagline. The blocks (and potentially other UIs in the editor) can then manipulate these settings ad hoc.

[jasmussen]

I took a stab at a few of the items on this list in #30526. Specifically the width, the placeholder, and the description.

[jameskoster]

If a logo hasn't already been set, I think it might be fun to programatically generate a logo upon insertion. This would fast-forward the user closer to where they want to be, and eliminate the need to the extra UI (placeholder) since they can simply use the already-familiar image tools to replace the auto-generated placeholder.

[mtias]

Description updated in #30909

[carolinan]

The alignments are only available if the logo is placed inside another block. It is a feature or side effect of the new way to handle layout/width settings #30568

[hedgefield]

Thanks for the PR Joen, it looks good! I do like the idea of a makeshift logo being generated, kinda like the icons in the plugin directory. I wonder how intuitive it is though for someone just expecting to get a box to upload a logo into. It might be a nice feature to have as a choice: upload your own or let WordPress generate something.

Is the needs design tag still on this issue for the 'allow site logo for site icon' flow?

[mtias]

The thing that still needs design work is how to present the site icon option.

[carolinan]

I pictured that option as a simple toggle in the block settings sidebar. Did you want it in the block toolbar?

[hedgefield]

Me too, something like a "Use site logo as icon" checkbox.

[mtias]

Definitely in settings, but we should properly explain what it is and we should consider the case when no site icon is set and you upload a logo, should we automatically set icon in such cases or ask users if they also want to use it there?

[creativecoder]

Related to these improvements, this seems like a good time to get the logo option name and data type aligned with existing conventions: #31511

[jffng]

Mentioning a small bug fix that will help for removing some logic from theme templates: #31513

[hedgefield]

Thinking about this some more I'm wondering where you would be able to set a site icon in the first place? I know where to find it in the old Customizer, but in FSE there's no block for it because it's not a visible element on the page, and I can't really find it under Templates either...

Ah I see that there's a separate issue for that #29126. I'll comment there too.

It does sound logical to have some kind of shortcut in the logo block for the site icon, but then I'd rather that is a link to the Site Icon setting itself, otherwise you're controlling two things from two places - like, would the "use logo as site icon" option on the logo block overrule what you set in the site icon option? Complex.

For the explanation, I think we can use the same one that exists in the customizer now:

[mtias]

@hedgefield we should at least account for the flow of uploading a site logo when no site icon is set; there should be a way (or maybe it's automatic) to also use that image for the site icon.

[ajlende]

Adding cropping in #31607 and updated the description to reflect that.

[carolinan]

There is also a problem with the resizing. #29217

[hedgefield]

How's this?

[jameskoster]

In #28341 (comment) I shared a concept that could allow folks to manipulate homepage settings in the midst of an editor session, via modal.

I wonder if there is potential to connect some dots here? IE clicking the "Site icon settings" link in @hedgefield's concept could potentially open the same "Site settings" modal, at a section that contains the site icon configuration options:

site.icon.mp4

[hedgefield]

That sounds like a proper good idea 👍

[youknowriad]

While trying to integrate this block into Core we had feedback about its storage. This is tracked separately here #32065 and is important to land in 5.8. For the remaining improvements tracked on this issue, we should consider them case by case as we're passed the feature freeze date.

[ramonjd]

Hello!

I think @stacimc's PR Site Logo: Add option to set site icon from Site Logo block #35892 is working well. I think I'm ready to approve, but it'd be good to get some confidence check 👀 from folks, or maybe @creativecoder (whose name I plucked from #32065).

Thank you!

[annezazu]

Just noting that #35892 got merged and have checked off that item above. This seems to be the final issue here so wondering if we can close? :) cc @priethor