[Block Library - Site Logo]: Return nothing if logo is not set #31513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Size Change: +309 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I was able to reproduce the problem, and the pr solves it. Sidenote: Without the customizer it is still not possible to remove the image from the logo block, only replace it or remove the entire block. |
carolinan
reviewed
May 6, 2021
Co-authored-by: Carolina Nymark <[email protected]>
ntsekouras
approved these changes
May 6, 2021
ntsekouras
changed the title
Added it as a task in #30406 so we remember. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the site logo block renders an empty div if the theme has support for a custom logo but the user has not set one.
This PR adjusts the render callback to return nothing if the custom logo has not been set.
How has this been tested?
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).