Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken padding in Search block's button #29952

Closed
fullofcaffeine opened this issue Mar 18, 2021 · 1 comment · Fixed by #32340
Closed

Broken padding in Search block's button #29952

fullofcaffeine opened this issue Mar 18, 2021 · 1 comment · Fixed by #32340
Assignees
Labels
[Block] Search Affects the Search Block - used to display a search field CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@fullofcaffeine
Copy link
Member

Description

The Search block's button's padding is broken. Tested with v10.2.0 (latest version at the time I'm writing this). See screenshot s below (tested with TwentyTwentyOne and Blank Canvas themes).

Step-by-step reproduction instructions

  1. Install v10.2.0 in your WordPress instance;
  2. Switch to the Blank Canvas theme;
  3. Create a new post or page;
  4. Insert a Search block;
  5. Observe how there's way too much padding at the bottom (or not enough at the other sides) making the button look odd and the text not centered.

Expected behaviour

The button should look well and balanced and not have the odd padding at the bottom.

Actual behaviour

There's way too much padding at the bottom (or not enough at the other sides) making the button look odd and the text not centered.

Screenshots or screen recording (optional)

Twenty Twenty One theme:

Screenshot 2021-03-11 at 10 48 47

Blank canvas theme:

Screenshot 2021-03-11 at 10 17 13

WordPress information

  • WordPress version: 5.8-alpha-50538.
  • Gutenberg version: v10.2.0.
  • Are all plugins except Gutenberg deactivated? Yes.
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes, but also tested with the Blank Canvas theme.

Device information

  • Device: Desktop.
  • Operating system: Ubuntu Linux 18.04.
  • Browser: Firefox Quantum 87.0b9 (64-bit).
@simison
Copy link
Member

simison commented May 25, 2021

Checked in Gutenberg 10.5 and TwentyTwentyOne, still happens:

image

Blank Canvas:

Screenshot 2021-05-25 at 20 43 49

I think this can also be theme-specific since it didn't happen with Alves theme:

Screenshot 2021-05-25 at 20 43 56

Perhaps the block needs to be a bit more defensive about its styles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Search Affects the Search Block - used to display a search field CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants