Gutenberg: v10.8.x plugin upgrade

[fullofcaffeine]

Previous upgrade: #53135.
Release notes: v10.8.0-rc.1, v10.8.0, v10.8.1.

• Install and activate
  • Copy & install v10.8.0-rc.1 (D62496-code, D62496-code)
  • Hotfix v10.8.0-rc.1 on edge to fix the WSOD issue (D62506-code)
  • Activate v10.8.0-rc.1 on edge (D62505-code)
  • Copy & install v10.8.0 (D62579-code, D62580-code)
  • Hotfix v10.8.0 on edge to fix the WSOD issue (D62581-code)
  • Activate v10.8.0 on edge (D62583-code)
  • iframe-server callback store fix (D62881-code)
  • Copy & install v10.8.1 (D62884-code, D62885-code)
  • Hotfix v10.8.1 on edge to fix the WSOD issue (D62887-code) >> last time we have to do this! << 🎉
  • Activate v10.8.1 on edge (D62888-code)
  • Activate v10.8.1 on production (D62508-code)
  • Request AT upgrade
  • Copy & install v10.8.2 (D62936-code, D62937-code)
  • Prepare a custom v10.8.2-with-min-js-assets based off this branch (D62953-code)
  • Copy v10.8.2 to custom v10.8.2-with-min-js-assets (D62949-code, D62954-code)
  • Activate v10.8.2-with-min-js-assets on edge (D62956-code)
  • Run tests for v10.8.2-with-min-js-assets - E2E and WPCOM
  • Fix WPCOM tests for v10.8.2-with-min-js-assets (D62958-code)
  • Deploy v10.8.2-with-min-js-assets to prod (D62958-code)
  • Request AT upgrade for v10.8.2
• Testing
  • Desktop viewport E2E
  • Mobile viewport E2E
  • WPCOM (D62508-code)
• Publish internal announcements
• Clean up unused releases
• Add log entry to the Gutenberg Upgrade Log [pcoGjb-g-p2]
• Open a new issue for the next upgrade, transfer remaining tasks, close this issue.

Blockers 🙅‍♀️

• "Move to trash" feature partially-failing because of wp-store reference ID type change in GB 10.8.
  • Reported and fixed in: [iframe-bridge-server/handlePostTrash] Get store namespace from store definition if available, fallback to assuming it's a string literal #53642 and respective diff (D62881-code)

Other issues 🐛

• More WPCOM minifier crashes

  • Reported in: p1623854536001500-slack-C02AVAR9B
  • Fixed by the custom v10.8.2-with-min-js-assets (see this Slack message for more details: p1623884834463400/1623884337.463300-slack-C7YPUHBB2 )
  • Won't be a problem with v10.9.0+

• Escaping issue with inline js caused error reporting to break the customizer

  • Reported in: [ErrorReporting] Use double-quotes to wrap the crossorigin attribute's value #53756
  • Fixed in: [ErrorReporting] Use double-quotes to wrap the crossorigin attribute's value #53756 and respective diff (D62948-code) (thanks for deploying @mattwiebe!)

• Page layout modal style issues

  • Reported in p1623855152031100-slack-CRNF6A9DX
  • Fixed in D62948-code

• jetpack/subscription block is triggering a lot of invalidation messages.

  • Discussed in: p1623796237416100/1623793937.415200-slack-C7YPUHBB2 and p1623795437120700-slack-CBG1CP4EN
  • Fixed in 10.8.2 (Revert fix/slug-to-classname WordPress/gutenberg#32742)

Transfered from previous release(s)

• wp-components's index.js is broken by the WPCOM minifier. There's a hotfix (D61090-code, D61091-code) applied in the RC1 that allowed us to ship it to simple sites for now. We still don't know what exactly in v10.6.0 RC1 caused this. We might need to be hotfixing on simple sites while we don't have a perm. solution. See: p1620321684463200-slack-C02A41GCS and p1620319065221200-slack-C4GAP2RHD.

  • Generate minified .min.js and unminified .js files for GB js entry points when building WordPress/gutenberg#31732

• P2 inline comments broken (and potentially other P2-related issues). Reported here: p1620327615008700-slack-C025Q5RK2 cc @johngodley (P2s have been pinned to 10.5.4 for now, see: p1621258202222400/1620838719.129600-slack-C7YPUHBB2, which makes this issue not a blocker for now).

• Search block's button padding is broken

  • Reported here: Broken padding in Search block's button WordPress/gutenberg#29952
  • Fixed in: Search block : Fix vertical alignment of search button text WordPress/gutenberg#32340

---

cc @inaikem

[fullofcaffeine]

P2 inline comments broken (and potentially other P2-related issues). Reported here: p1620327615008700-slack-C025Q5RK2 cc @johngodley (P2s have been pinned to 10.5.4 for now, see: p1621258202222400/1620838719.129600-slack-C7YPUHBB2, which makes this issue not a blocker for now).

@johngodley Is this still an issue?

[fullofcaffeine]

Next one: #53725.

[johngodley]

@johngodley Is this still an issue?

Kind of, but for a different bug introduced in Gutenberg 10.7.x and fixed in 10.8. P2 itself has been updated and should run fine on 10.7 and 10.8. I'll wait for 10.8 to settle down and if it's solid I'll unpin P2, otherwise I have a fix for 10.7 to get it running there.