E2E: stabilize failing tests in trunk #29836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
mkaz
reviewed
Mar 12, 2021
|
Looking into the failure from Looks green after a second run but @ellatrix does the suite I'm seeing the cursor on the page title for the |
gwwar
force-pushed
the
fix/failing-e2e-tests
branch
from
6bb60bd to
2a3d9a7
Compare
|
This one is ready for review ✅ |
5 tasks
mkaz
approved these changes
Mar 12, 2021
talldan
reviewed
Mar 15, 2021
| // 'button[aria-label="Add block"]' | ||
| // ); | ||
| // await appender.click(); | ||
| const appender = await page.waitForSelector( |
There was a problem hiding this comment.
@gwwar Thanks for switching this back. I'm curious - did the underlying issue (with variations not being available) get fixed here, or did it fix itself?
There was a problem hiding this comment.
Maybe from the server-side piece landing? WordPress/wordpress-develop#1015 (comment)
This was referenced Mar 15, 2021
|
I guess you resolved the multi select problem? |
7 tasks
@ellatrix it resolved itself with another run on CI, but I was curious if it was working for folks locally. |
|
What do you get as a result? I have a failure in |
I do too, it appears to be okay in CI somehow. Running locally, focus is set on the post title. |
|
Sounds like it could use a separate issue and further investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes breaking E2E tests that are present in trunk. See example run
Having flakey/broken tests in trunk reduces confidence in tests. After verifying if it's a real breakage let's fix or disable them. If it's a tricky one to test, it's okay to skip, but then follow up with a more stable test.
Testing Instructions
Local and CI runs for this branch should be green: