Navigation: nav created drafts should not render on frontend #29692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +163 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
annezazu
reviewed
Mar 10, 2021
There was a problem hiding this comment.
I tested this by installing the Gutenberg plugin built with this PR and testing adding a link, creating a draft page, and viewing the front end. I can confirm this works as expected and resolves the original reported problem. Someone else will need to chime in to review the code and do more testing.
gwwar
requested review from
adamziel,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Edit: Looks like I'll need this |
|
Since we can load in menus created from the navigation editor, I'll also want to make sure that I'll tackle that tomorrow. Changes here are okay to test on the post-editor side of things. |
gwwar
force-pushed
the
fix/navigation-created-draft
branch
from
c93da7f to
af813c4
Compare
|
I'm holding off on any navigation editor changes until we clarify intended behavior in #29793 If we'd like changes in behavior, I think it makes sense to split that out to a follow up PR, since it might be a bigger of a change. |
gwwar
force-pushed
the
fix/navigation-created-draft
branch
2 times, most recently
from
b429519 to
bc4936c
Compare
|
This one is ready for review ✅ E2E breakages are unrelated and should be fixed by #29836 |
gwwar
force-pushed
the
fix/navigation-created-draft
branch
from
bc4936c to
e68b951
Compare
|
@Addison-Stavlo noticed differing site-editor behavior in #29396. It looks like there's another I'll try to fix that in a different PR, by having all editor implementations use a single implementation. |
gwwar
force-pushed
the
fix/navigation-created-draft
branch
from
e68b951 to
c015700
Compare
|
Rebased to pick up refactor + fixes in #29993 ✅ This one is ready for review. |
mkaz
approved these changes
Apr 7, 2021
|
Thanks for the review @mkaz! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29691
Problem
Some drafts will render on the published page/post frontend. This happens in two ways:
create-a-draft.mp4
link.mp4
Why Does This Happen?
In trunk when we link from the general "link" variation this is missing the "type" attribute. Without this information, we can't blindly check to see if an id is a draft. It might actually be a term-id, leading to a bug like: #28712
Proposed changes:
Changes in this PR add the
typeblock attributes to the link consistently regardless of what link variation we use to create the link. This will fix newly added links but not existing links. (The worst case is that we have an old link to a draft that still renders on the front end).In order to support future custom post types and taxonomies, we should also return the
kind(taxonomy|post-type) to make this more clear. Type is not enough information to differentiate if we can check for draft status besides our built-in types (post,page,post_tag,category).Example custom PortfolioTag Search Result:
Before:
After:
Testing Instructions w/ WP 5.7
kindandtypeattributes are present and make sense.If it's a draft, verify that the link is visible only in the editor, but not on the published page of the navigation links.
Verify that links like
www.wordpress.orgdo not contain theidtypeorkindblock attributes.Testing Instructions w/ WP latest (Custom Link Variations)
item_linkanditem_link_descriptionkindandtypeattributes are present and make sense.kindandtypeattributes are present and make sense.www.wordpress.orgdo not contain theid,typeorkindblock attributes.Test Post-Format Links
A post format link looks like
http://wordpress.local/type/quote/. This points at the archive of a post type format like quote or image.To test:
Install a theme that supports post-formats like Twenty Thirteen
Create a post using one of the post-format types like "Quote"
Add a navigation block
Add a navigation link using the general link variation
Search for the post-format and individual quote
Verify that the individual link to a quote has type 'post' and kind 'post-type'.
Verify that the link to the post-format only has
urlandlabelBehavior when loading links from a menu
TODO:
packages/editor/src/components/provider/use-block-editor-settings.jstopackages/edit-navigation/src/index.js.