Set delay to zero in the reduce-motion mixin and tests #29762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Type] Bug
david-szabo97
requested review from
mattwiebe,
youknowriad,
mtias,
vindl,
kjellr,
creativecoder,
Copons,
jeyip,
ntsekouras and
Addison-Stavlo
7 tasks
|
Size Change: +298 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
(Make sure to test this PR properly cross browsers, I know for instance that Safari might treat these default values differently) |
7 tasks
|
Thanks for the heads-up! I've tested the latest Chrome, Firefox, Edge, and Safari. So far everything works fine. |
gziolo
added
the
[Type] Automated Testing
gziolo
approved these changes
Mar 11, 2021
creativecoder
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Confirming that this fixes the trouble I was having in #29489. With this change applied, template-part.test.js tests pass for me locally.
7 tasks
david-szabo97
force-pushed
the
fix/reduce-motion-override-delay-too
branch
from
43ebb01 to
9d9def4
Compare
|
Rebased, hopefully tests will be happy now 🤞 |
This was referenced Mar 17, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set
transition-delayandanimation-delayto0s(basically disabling it) in thereduce-motionmixin and E2E tests plugin.How has this been tested?
Screenshots
Note, in the video you will see the inserter button to slide to the left in a smooth way. This transition doesn't have
reduce-motionmixin yet. That's another bug and a separate PR will fix that.Inserter button goes behind the W button. And after a few milliseconds, it appears next to the W button. We use
transition-delayto coordinate the transitions, that's why this is happening. To fix this, we need to set the delay to zero in reduced-motion mode.Before
Screen.Recording.2021-03-11.at.11.24.55.mov
After
Screen.Recording.2021-03-11.at.11.27.56.mov
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: