Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Dead Readme Link? #29696

Closed
StevenDufresne opened this issue Mar 10, 2021 · 0 comments · Fixed by #29699
Closed

i18n: Dead Readme Link? #29696

StevenDufresne opened this issue Mar 10, 2021 · 0 comments · Fixed by #29699
Labels
[Package] i18n /packages/i18n [Status] In Progress Tracking issues with work in progress

Comments

@StevenDufresne
Copy link
Contributor

Description

There is a link in the i18n readme that doesn't appear to make sense and probably should be removed. Without understanding the context, I'm not certain where it should be linking to. It takes me to a weird forum.

It was introduced in this PR: #14266

File in question: https://github.com/WordPress/gutenberg/blob/trunk/packages/i18n/README.md
Link in Question: http://www.diveintojavascript.com/projects/javascript-sprintf
@StevenDufresne StevenDufresne added the [Package] i18n /packages/i18n label Mar 10, 2021
@lephleg lephleg mentioned this issue Mar 10, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 10, 2021
@oandregal oandregal removed their assignment Mar 10, 2021
lephleg added a commit to lephleg/gutenberg that referenced this issue Mar 10, 2021
@lephleg
i18n: Replace dead link in README.md.
d4981c0 
Fixes WordPress#29696.
talldan pushed a commit that referenced this issue Mar 15, 2021
@lephleg
i18n: Replace dead link in README.md. (#29699)
bc75b62 
Fixes #29696.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] i18n /packages/i18n [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i18n: Replace dead link in README.md. lephleg/gutenberg
2 participants
@oandregal @StevenDufresne