Don't display Guide's page control if there is only one page #29629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +27 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Aljullu
force-pushed
the
fix/29628-guide-single-page
branch
from
e7a8ff7 to
0828227
Compare
noisysocks
approved these changes
Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29628.
Description
Until now,
Guideassumed there will always be more than one page, so thePageControlwas always displayed under the image. However, when there is only one page, that control is useless and can be distracting. This PR hides thePageControlwhen only one page is available.This PR also refactors the styles a bit. Currently,
Guidewas relying on the margin added by the page control to separate the image and the text below. Given that this is no longer always present, I moved some of the styles to the Welcome guide CSS (see screenshots below for the end result).How has this been tested?
Testing steps:
Guidecomponent, set thenumberOfPagesto 1.PageControlis not visible.Test no regressions in the Welcome guide:
WP_DATA_USER_1value sowelcomeGuideincore/edit-postis false. This will force the Welcome guide to appear next time you visit the editor.Screenshots
Guide with only one page:
I used the welcome guide to simulate more combinations and also to test the style changes included in this PR:
Types of changes
Behavior change in the
Guidecomponent from@wordpress/components.Checklist: