Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide shouldn't show the PageControl if there is only one page #29628

Closed
Aljullu opened this issue Mar 8, 2021 · 0 comments · Fixed by #29629
Closed

Guide shouldn't show the PageControl if there is only one page #29628

Aljullu opened this issue Mar 8, 2021 · 0 comments · Fixed by #29629
Assignees
@Aljullu
Labels
[Package] Components /packages/components

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Mar 8, 2021

Description

Currently, Guide assumes there will always be more than one page, so the PageControl is always displayed under the image. However, when there is only one page, that control can be distracting and is useless. This issue is about hiding the PageControl when only one page is available.

Step-by-step reproduction instructions

  1. In the Storybook page for the Guide component, set the numberOfPages to 1.
  2. Notice the blue dot of the PageControl is still visible:

Screenshot showing the Guide with only one page

Expected behaviour

If there is only one page, the PageControl shouldn't be displayed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aljullu Aljullu

Labels
[Package] Components /packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't display Guide's page control if there is only one page WordPress/gutenberg
1 participant
@Aljullu