Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-between inserter not working in the Navigation Block #28313

Closed
talldan opened this issue Jan 19, 2021 · 0 comments · Fixed by #28833
Closed

In-between inserter not working in the Navigation Block #28313

talldan opened this issue Jan 19, 2021 · 0 comments · Fixed by #28833
Assignees
@jasmussen
Labels
[Block] Navigation Affects the Navigation Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jan 19, 2021

Description

#27860 adds support for the in-between inserter in horizontal block lists (Buttons, Columns, Social):
Screenshot 2021-01-19 at 12 21 11 pm

But it still doesn't work in the (horizontal variation of the) navigation block for inserting between items. As mentioned in this comment, that seems to be because of a styling issue: #27860 (comment)

Step-by-step reproduction instructions

  1. Add a Navigation Block
  2. Add at least two links
  3. Hover between the blocks and try to make the in-between inserter appear

Expected behaviour

It appears

Actual behaviour

It doesn't appear

WordPress information

  • WordPress version: 5.6
  • Gutenberg version: 9.8rc1
  • Are all plugins except Gutenberg deactivated? Y
  • Are you using a default theme (e.g. Twenty Twenty-One)? Y (2021)

Device information

  • Device: Desktop
  • Operating system: Mac OS
  • Browser: Brave
@talldan talldan added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block CSS Styling Related to editor and front end styles, CSS-specific issues. labels Jan 19, 2021
jasmussen added a commit that referenced this issue Feb 8, 2021
@jasmussen
Try: Allow vertical inserter in the nav block.
3470e00 
Fixes #28313.
@jasmussen jasmussen mentioned this issue Feb 8, 2021
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 8, 2021
jasmussen added a commit that referenced this issue Feb 9, 2021
@jasmussen
Try: Allow vertical inserter in the nav block.
025707c 
Fixes #28313.
jasmussen added a commit that referenced this issue Feb 11, 2021
@jasmussen
Try: Allow vertical inserter in the nav block.
fffd920 
Fixes #28313.
jasmussen added a commit that referenced this issue Mar 12, 2021
@jasmussen
Try: Allow vertical inserter in the nav block.
4cd0ad1 
Fixes #28313.
jasmussen added a commit that referenced this issue Mar 12, 2021
@jasmussen
Try: Allow vertical inserter in the nav block. (#28833)
17be89a 
Fixes #28313.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Block] Navigation Affects the Navigation Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try: Allow vertical inserter in the nav block. WordPress/gutenberg
2 participants
@talldan @jasmussen