Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Nav Sidebar Toggle Button Disappears in Smaller Viewports #26754

Closed
jeyip opened this issue Nov 5, 2020 · 1 comment
Closed

Site Editor: Nav Sidebar Toggle Button Disappears in Smaller Viewports #26754

jeyip opened this issue Nov 5, 2020 · 1 comment
Assignees
@mattwiebe
Labels
Needs Design Feedback Needs general design feedback. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jeyip
Copy link
Contributor

jeyip commented Nov 5, 2020

Describe the bug
More context here

At smaller viewport widths, we can open the Navigation sidebar by clicking on the name of the current template then clicking on "Browse templates". This opens the sidebar but there is no way to close it.

To reproduce
Steps to reproduce the behavior:

  1. Enable the site editor locally
  2. Navigate to the site editor
  3. Shrink the viewport <782px
  4. Click on the document title
  5. Click on "browse all templates"

Expected behavior
If we want to include the nav sidebar for smaller viewports, then we should render the hide nav sidebar button. Otherwise, we could remove the "browse all templates" button from the document title dropdown at smaller viewports.

Screenshots
Screen Shot 2020-11-05 at 3 03 35 PM
Screen Shot 2020-11-05 at 3 05 01 PM
@jeyip jeyip added [Type] Bug An existing feature does not function as intended [Feature] Full Site Editing labels Nov 5, 2020
@jeyip jeyip changed the title Site Editor: Navigation Sidebar Site Editor: Nav Sidebar Toggle Button Disappears in Smaller Viewports Nov 5, 2020
@jeyip jeyip mentioned this issue Nov 5, 2020
Merged
@jeyip jeyip added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Nov 5, 2020
@vindl vindl added the Needs Design Feedback Needs general design feedback. label Nov 6, 2020
@mattwiebe mattwiebe self-assigned this Nov 26, 2020
mattwiebe added a commit that referenced this issue Nov 26, 2020
@mattwiebe
Site Editor: fix app header on small-medium screens
c72bae4 
Especially in contexts with the navigation sidebar open

Fixes #27245 #26754
@mattwiebe mattwiebe mentioned this issue Nov 26, 2020
Merged
6 tasks
@mattwiebe mattwiebe added the [Status] In Progress Tracking issues with work in progress label Nov 26, 2020
mattwiebe added a commit that referenced this issue Nov 27, 2020
@mattwiebe
Site Editor: fix app header on small-medium screens (#27310)
2370863 
Especially in contexts with the navigation sidebar open

Fixes #27245 #26754
@mattwiebe
Copy link
Contributor

Fixed in #27310 but GitHub doesn't like to close multiple issues with one line

Why do you hate efficiency, Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattwiebe mattwiebe

Labels
Needs Design Feedback Needs general design feedback. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattwiebe @vindl @jeyip