Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media replace flow doesn't show errors #19156

Closed
draganescu opened this issue Dec 16, 2019 · 2 comments · Fixed by #19244
Closed

Media replace flow doesn't show errors #19156

draganescu opened this issue Dec 16, 2019 · 2 comments · Fixed by #19244
Assignees
Labels
[Block] Image Affects the Image Block Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Milestone

Comments

@draganescu
Copy link
Contributor

draganescu commented Dec 16, 2019

Describe the bug
The new component which handles media replace flow does not show erros, as it leaves this to the parent component. However, the parent comonents where this new flow needs to be implemented relied on an "editing" state where the media was absent and a placeholder would display both edit actions and eventual erroes.

In all the

To reproduce
Steps to reproduce the behavior:

  1. Try to upload an oversized image
  2. Observe it failed but no message was shown

Expected behavior
A clear and concise message should be shown somewhere. Where?

Given the lack of space in the media blocs when displaying media or "players", should we use a snackbar?

@draganescu draganescu added [Type] Bug An existing feature does not function as intended Needs Design Needs design efforts. [Block] Image Affects the Image Block labels Dec 16, 2019
@draganescu draganescu added this to the Future milestone Dec 16, 2019
@draganescu draganescu self-assigned this Dec 16, 2019
@karmatosed
Copy link
Member

I would advise against snackbars for this as it's not right by where the error occurs and it's also the wrong use of that style of the component.

A possible 'quick fix' would be:

narrow

Or, a simpler:

wide

Once this link interface iterates that could be used also:

link

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Dec 16, 2019
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 19, 2019
@draganescu
Copy link
Contributor Author

@karmatosed I implemented the 1st option above in #19244 as it was the one that kept the errors in the same place as where the action happened.

I used the standard noticeUI (which the placeholder also uses) and fixed a bit of CSS to make it fit the smaller space of the replace menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants