Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media text block doesn't show upload errors #15684

Closed
thesquaremedia opened this issue May 16, 2019 · 2 comments
Closed

Media text block doesn't show upload errors #15684

thesquaremedia opened this issue May 16, 2019 · 2 comments
Assignees
Labels
[Block] Media & Text Affects the Media & Text Block Needs Design Needs design efforts.

Comments

@thesquaremedia
Copy link

Describe the bug
When I upload an image that would throw an upload error such as an image bigger than the allowed size. The Block won't display any errors.

To reproduce
Steps to reproduce the behavior:

  1. Go to 'Page/Post and add the media and text block'
  2. Click on 'Upload Image'
  3. Upload an image larger than the allowed size.'
  4. Notice that the block wont do anything and wont display an error like other image blocks do.

Expected behavior
We should be able to see an upload related error like in the other image blocks.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser Safari
  • Version Mojave

Additional context

  • Wordpress 5.1.1
@swissspidy swissspidy added the [Block] Media & Text Affects the Media & Text Block label May 16, 2019
@draganescu draganescu added the Needs Design Needs design efforts. label Dec 16, 2019
@draganescu draganescu self-assigned this Dec 16, 2019
@draganescu
Copy link
Contributor

draganescu commented Dec 16, 2019

Related: #19156

@mapk
Copy link
Contributor

mapk commented Dec 27, 2019

I just tested this out with WordPress 5.3 on Firefox 71.0 and got the error messages as expected. Perhaps this has already been resolved.

Image block

Screen Shot 2019-12-27 at 2 12 02 PM

Media + Text block

Screen Shot 2019-12-27 at 2 12 46 PM

I'll close this issue for now keeping in mind there is discussion about where we display these errors in #19156.

@mapk mapk closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

4 participants