Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break lines with BRs when applying lists #158

Closed
androb opened this issue Mar 1, 2017 · 5 comments · May be fixed by tzavagno/gutenberg#4
Closed

Break lines with BRs when applying lists #158

androb opened this issue Mar 1, 2017 · 5 comments · May be fixed by tzavagno/gutenberg#4
Assignees
Labels
[Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@androb
Copy link
Contributor

androb commented Mar 1, 2017

Requirement from: https://wordpress.slack.com/archives/core-editor/p1484770058001584

Highlight a bunch of text with br, press the list button, and have it be a series of list items rather than one block of text inside a single li

@androb androb self-assigned this Mar 1, 2017
@androb androb added the [Type] Enhancement A suggestion for improvement. label Mar 1, 2017
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Mar 7, 2017
@ellatrix
Copy link
Member

@jasmussen jasmussen modified the milestones: May Week 3 (Alpha), Beta May 16, 2017
@mtias mtias modified the milestones: Beta 2, Beta Jun 15, 2017
@ellatrix
Copy link
Member

Is this done? I think this was added by @notnownikki?

@ellatrix
Copy link
Member

I do get a warning though.

Warning: Each child in an array or iterator should have a unique "key" prop.

Check the top-level render call using <ul>. See https://fb.me/react-warning-keys for more information.
    in li

@notnownikki
Copy link
Member

I thought this was working... It's possible something else has broken it though, will look at it today.

@notnownikki
Copy link
Member

Ah, looks like #2343 is open for fixing this.

This was working at one point, but I don't think there are tests for the transforms, which we should add to make sure formatting changes don't break stuff again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants