Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropZone: Allow overriding children #14335

Open
swissspidy opened this issue Mar 8, 2019 · 1 comment
Open

DropZone: Allow overriding children #14335

swissspidy opened this issue Mar 8, 2019 · 1 comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@swissspidy
Copy link
Member

Is your feature request related to a problem? Please describe.

I am trying to use the DropZone component together with Draggable to implement a simple sorting mechanism.

While doing so, I realized I can change the default "Drop files to upload" label, but not the upload icon.

In the 'BlockDropZone' component, this is "solved" by just hiding the content using CSS, which isn't really nice, but currently the only way to achieve this.

Describe the solution you'd like

It would be way easier if we could pass custom content as children or have some other way to remove the default content in DropZone.

@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement. [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Mar 8, 2019
@youknowriad
Copy link
Contributor

youknowriad commented Apr 10, 2020

Just nothing that there's a __unstableUseDropZone react hook allowing alternative UIs for drop zones. We should probably consider making this API stable instead of adding children support to DropZone.

Ideally, we'd also avoid the need for a DropzoneProvider at some point.

@mirka mirka added the [Package] Components /packages/components label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants