Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Block: Adding a custom class results in loss of block styles in the editor. #13430

Closed
kjellr opened this issue Jan 22, 2019 · 0 comments
Closed

File Block: Adding a custom class results in loss of block styles in the editor. #13430

kjellr opened this issue Jan 22, 2019 · 0 comments
Assignees
@Soean
Labels
[Block] File Affects the File Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Jan 22, 2019

As reported by @uamv in #8295:

This appears to be a bug, though I've not tested with a clean install. When I add a custom class to the file block, the Download button loses styling on the back end. The front-end styling still appears properly.

46106541-fa210500-c1a6-11e8-96e8-6adc0d32a282

I'm able to reproduce on master.
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Block] File Affects the File Block labels Jan 22, 2019
@Soean Soean self-assigned this Jan 22, 2019
@Soean Soean mentioned this issue Jan 22, 2019
Merged
jorgefilipecosta pushed a commit that referenced this issue Jan 23, 2019
@Soean @jorgefilipecosta
Fix: File block add custom class (#13432)
22abc9e 
## Description
The custom class should only be added to the wrapper, not every div
Fixes #13430
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@Soean @youknowriad
Fix: File block add custom class (#13432)
53067fd 
## Description
The custom class should only be added to the wrapper, not every div
Fixes #13430
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@Soean @youknowriad
Fix: File block add custom class (#13432)
9547b88 
## Description
The custom class should only be added to the wrapper, not every div
Fixes #13430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soean Soean

Labels
[Block] File Affects the File Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Soean @kjellr