-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting empty text area not possible without adding text into area #10334
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Milestone
Comments
tofumatt
added
the
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
label
Oct 4, 2018
I think that looks great! I'm not sure but I suspect this but issue affects
me more than average so I think the delete option is probably more
preferable than making it harder to add a box by accident.
Could the option be selected by default so hitting enter key (before any
content is added) would delete the box in one click?
Thanks
Anna
…On Sun, 14 Oct 2018, 00:04 Keanan Koppenhaver, ***@***.***> wrote:
One way I've been thinking about this would be to put a delete icon in the
inserter that shows up when the block has no content.
[image: screen shot 2018-10-13 at 6 01 49 pm]
<https://user-images.githubusercontent.com/2965444/46910879-3deb6c80-cf12-11e8-9c84-3e7f57214a35.png>
[image: screen shot 2018-10-13 at 6 02 57 pm]
<https://user-images.githubusercontent.com/2965444/46910880-42b02080-cf12-11e8-93a0-ff710bbeb0e5.png>
Would be interested in hearing some thoughts on this approach or possible
alternatives. Once we decide, I can likely tackle this in the next couple
days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10334 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACuIsPlA9XUVFHqBpCryL25qYIriHkaUks5uknF1gaJpZM4XIdND>
.
|
I agree there shoud be dashicon trash icon there. Planty of space, even in mobile. |
The in-between inserter no longer automatically creates a paragraph block. As of #11018, it now shows the default inserter menu. As such, it's my understanding this issue would no longer be relevant? Let me know if it is and it can be reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Describe the bug
I have mobility issues and keep accidentally clicking the plus icon at the top of a block, which inserts and new empty block above. There is no way to then delete this new block. The only way I have found is to put text (just a random letter) in the block which makes the menu pop up, so I can click the three dots and then remove the block.
It's a small thing in manyways, however, building one page I did this about 10 times and it was extremely annoying/frustrating.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Simple x or similar, to be able to remove an empty block. Should be one click.
Screenshots
If applicable, add screenshots to help explain your problem.
https://greencloud.gn.apc.org/index.php/s/SDo3PeMeDJ6zwFX
https://greencloud.gn.apc.org/index.php/s/LHCQxHdwCBxbdJ2
https://greencloud.gn.apc.org/index.php/s/LHCQxHdwCBxbdJ2
https://greencloud.gn.apc.org/index.php/s/waws8MkX7fscsXC
Desktop (please complete the following information):
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: