Fix resetting of opacity when cover has media background

WordPress · Jun 6, 2022 · f400907 · f400907
1 parent 6b05ca5
commit f400907
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/packages/block-library/src/cover/edit/inspector-controls.js b/packages/block-library/src/cover/edit/inspector-controls.js
@@ -250,12 +250,20 @@ export default function CoverInspectorControls( {
 					{ ...colorGradientSettings }
 				/>
 				<ToolsPanelItem
-					hasValue={ () => !! dimRatio }
+					hasValue={ () => {
+						// If there's a media background the dimRatio will be
+						// defaulted to 50 whereas it will be 100 for colors.
+						return dimRatio === undefined
+							? false
+							: dimRatio !== ( url ? 50 : 100 );
+					} }
 					label={ __( 'Overlay opacity' ) }
 					onDeselect={ () =>
-						setAttributes( { dimRatio: undefined } )
+						setAttributes( { dimRatio: url ? 50 : 100 } )
 					}
-					resetAllFilter={ () => ( { dimRatio: undefined } ) }
+					resetAllFilter={ () => ( {
+						dimRatio: url ? 50 : 100,
+					} ) }
 					isShownByDefault
 					panelId={ clientId }
 				>