Font Library: Fix font installation failure (#55893)

* Font Library: Fix font installation failure * Made 'has_upload_director' private --------- Co-authored-by: Jason Crist <[email protected]>
WordPress · Nov 7, 2023 · eba64ca · eba64ca · github-actions · Nov 7, 2023
1 parent 659c960
commit eba64ca
Showing 1 changed file with 35 additions and 6 deletions.
diff --git a/lib/experimental/fonts/font-library/class-wp-rest-font-library-controller.php b/lib/experimental/fonts/font-library/class-wp-rest-font-library-controller.php
@@ -344,6 +344,18 @@ public function update_font_library_permissions_check() {
 		return true;
 	}
 
+	/**
+	 * Checks whether the font directory exists or not.
+	 *
+	 * @since 6.5.0
+	 *
+	 * @return bool Whether the font directory exists.
+	 */
+	private function has_upload_directory() {
+		$upload_dir = WP_Font_Library::get_fonts_dir();
+		return is_dir( $upload_dir );
+	}
+
 	/**
 	 * Checks whether the user has write permissions to the temp and fonts directories.
 	 *
@@ -418,12 +430,29 @@ public function install_fonts( $request ) {
 			$response_status = 400;
 		}
 
-		if ( $this->needs_write_permission( $fonts_to_install ) && ! $this->has_write_permission() ) {
-			$errors[]        = new WP_Error(
-				'cannot_write_fonts_folder',
-				__( 'Error: WordPress does not have permission to write the fonts folder on your server.', 'gutenberg' )
-			);
-			$response_status = 500;
+		if ( $this->needs_write_permission( $fonts_to_install ) ) {
+			$upload_dir = WP_Font_Library::get_fonts_dir();
+			if ( ! $this->has_upload_directory() ) {
+				if ( ! wp_mkdir_p( $upload_dir ) ) {
+					$errors[] = new WP_Error(
+						'cannot_create_fonts_folder',
+						sprintf(
+							/* translators: %s: Directory path. */
+							__( 'Error: Unable to create directory %s.', 'gutenberg' ),
+							esc_html( $upload_dir )
+						)
+					);
+					$response_status = 500;
+				}
+			}
+
+			if ( $this->has_upload_directory() && ! $this->has_write_permission() ) {
+				$errors[]        = new WP_Error(
+					'cannot_write_fonts_folder',
+					__( 'Error: WordPress does not have permission to write the fonts folder on your server.', 'gutenberg' )
+				);
+				$response_status = 500;
+			}
 		}
 
 		if ( ! empty( $errors ) ) {