Fix sync filter reset check

WordPress · Sep 13, 2023 · da77818 · da77818
1 parent a37cdd3
commit da77818
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packages/block-editor/src/components/inserter/block-patterns-explorer/explorer.js b/packages/block-editor/src/components/inserter/block-patterns-explorer/explorer.js
@@ -32,10 +32,7 @@ function PatternsExplorer( { initialCategory, rootClientId } ) {
 	// If the sync filter changes, we need to select the "All" category to avoid
 	// showing a confusing no results screen.
 	useEffect( () => {
-		if (
-			patternSyncFilter !== null &&
-			previousSyncFilter !== patternSyncFilter
-		) {
+		if ( patternSyncFilter && patternSyncFilter !== previousSyncFilter ) {
 			setSelectedCategory( initialCategory?.name );
 		}
 	}, [

diff --git a/packages/block-editor/src/components/inserter/block-patterns-tab.js b/packages/block-editor/src/components/inserter/block-patterns-tab.js
@@ -318,8 +318,7 @@ function BlockPatternsTabs( {
 	const previousSyncFilter = usePrevious( patternSyncFilter );
 
 	// If the sync filter changes, we need to select the "All" category to avoid
-	// showing a confusing no results screen. We also need to clear the category
-	// selection when the component unmounts.
+	// showing a confusing no results screen.
 	useEffect( () => {
 		if ( patternSyncFilter && patternSyncFilter !== previousSyncFilter ) {
 			onSelectCategory( allPatternsCategory, patternSourceFilter );