Skip to content

Commit

Permalink
Fix Storybook build which broke after Typescript 5 update (#53445)
Browse files Browse the repository at this point in the history
  • Loading branch information
noahtallen authored Aug 8, 2023
1 parent 2fe728e commit c94eca5
Show file tree
Hide file tree
Showing 3 changed files with 124 additions and 0 deletions.
116 changes: 116 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@
"prettier": "npm:[email protected]",
"progress": "2.0.3",
"react": "18.2.0",
"react-docgen-typescript-plugin": "1.0.5",
"react-dom": "18.2.0",
"react-native": "0.71.11",
"react-native-url-polyfill": "1.1.2",
Expand Down
7 changes: 7 additions & 0 deletions storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,11 @@ module.exports = {
emotionAlias: false,
storyStoreV7: true,
},
typescript: {
// TODO: this can likely be removed after upgrading to Storybook 7, along
// with the root-level dependency on react-docgen-typescript-plugin. Without
// this, Storybook crashes when building with Typescript 5.x.
// See https://github.com/hipstersmoothie/react-docgen-typescript-plugin/issues/78#issuecomment-1409224863.
reactDocgen: 'react-docgen-typescript-plugin',
},
};

0 comments on commit c94eca5

Please sign in to comment.