Make sure WP_Theme_JSON_Gutenberg::resolve_variables returns $theme_json

WordPress · Jun 19, 2023 · bcb6c73 · bcb6c73
1 parent ddef167
commit bcb6c73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/class-wp-theme-json-gutenberg.php b/lib/class-wp-theme-json-gutenberg.php
@@ -3699,7 +3699,7 @@ private static function convert_variables_to_value( $styles, $values ) {
 	 * @since 6.3.0
 	 * @param WP_Theme_JSON_Gutenberg $theme_json The theme json resolver.
 	 *
-	 * @return array The styles with the variables replaced with their values.
+	 * @return WP_Theme_JSON_Gutenberg The $theme_json with resolved variables.
 	 */
 	public static function resolve_variables( $theme_json ) {
 		$settings    = $theme_json->get_settings();
@@ -3716,7 +3716,8 @@ function( $carry, $item ) {
 			array()
 		);
 
-		return self::convert_variables_to_value( $styles, $vars );
+		$theme_json->theme_json['styles'] = self::convert_variables_to_value( $styles, $vars );
+		return $theme_json;
 	}
 
 }
diff --git a/phpunit/class-wp-theme-json-test.php b/phpunit/class-wp-theme-json-test.php
@@ -2135,7 +2135,7 @@ public function test_resolve_variables() {
 			)
 		);
 
-		$styles = $theme_json::resolve_variables( $theme_json );
+		$styles = $theme_json::resolve_variables( $theme_json )->get_raw_data()['styles'];
 
 		$this->assertEquals( $primary_color, $styles['color']['background'], 'Top level: Assert values are converted' );
 		$this->assertEquals( $raw_color_value, $styles['color']['text'], 'Top level: Assert raw values stay intact' );