-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clone switcher controls into each block
- Allows on-hover reveal of switcher to happen reliably with CSS - Requires refactoring of a few event-binding functions in order for them to operate on blocks rather than on a singleton node. - Reliance on the `selectedBlock` global is diminished. The drawback is a more hybrid code base, where some logic expects `selectedBlock` and some doesn't need it. The advantage is that less mutating state needs to be managed (setting `selectedBlock` can be delayed up until the point it is necessary for a given operation). - A couple of TypeErrors may pop up in the console. I suspect there are some interactions where the target block isn't defined. Needs to be addressed.
- Loading branch information
Showing
2 changed files
with
67 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters