Skip to content

Commit

Permalink
Try fixing nav menu scroll
Browse files Browse the repository at this point in the history
This fixes #4445. Props @m-e-h to starting the work to address this.

This removes `overflow: hidden;` from the `body` element, which was previously applied at the desktop breakpoint. That means if you have a very tall navigation menu, or your viewport isn't very tall, then you can at least scroll the main container to reveal all menu items.

This is not an ideal fix, as it adds another scrollbar in this edgecase. But given it's an edgecase, and given the benefits of preventing scroll bleed the individually scrolling main content area has, perhaps it's worth it?

We need to test this PR to see that there aren't other side effects.

We also tried letting the nav container itself scroll, but that crops the flyout menu.
  • Loading branch information
Joen Asmussen committed Jan 22, 2018
1 parent 25d90ca commit a0b61c9
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions editor/assets/stylesheets/main.scss
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
body.gutenberg-editor-page {
background: $white;

// on mobile the main content area has to scroll
// otherwise you can invoke the overscroll bounce on the non-scrolling container, causing (ノಠ益ಠ)ノ彡┻━┻
@include break-small {
overflow: hidden;
}

#update-nag, .update-nag {
display: none;
}
Expand Down

0 comments on commit a0b61c9

Please sign in to comment.