Skip to content

Commit

Permalink
Also close settings menu after other items
Browse files Browse the repository at this point in the history
See #15313
  • Loading branch information
swissspidy committed May 10, 2019
1 parent 7d4b257 commit 957e0c8
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions packages/block-editor/src/components/block-settings-menu/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ export function BlockSettingsMenu( { clientIds, onSelect } ) {
{ ! isLocked && canDuplicate && (
<MenuItem
className="editor-block-settings-menu__control block-editor-block-settings-menu__control"
onClick={ onDuplicate }
onClick={ () => {
onClose();
onDuplicate();
} }
icon="admin-page"
shortcut={ shortcuts.duplicate.display }
>
Expand All @@ -81,15 +84,21 @@ export function BlockSettingsMenu( { clientIds, onSelect } ) {
<>
<MenuItem
className="editor-block-settings-menu__control block-editor-block-settings-menu__control"
onClick={ onInsertBefore }
onClick={ () => {
onClose();
onInsertBefore();
} }
icon="insert-before"
shortcut={ shortcuts.insertBefore.display }
>
{ __( 'Insert Before' ) }
</MenuItem>
<MenuItem
className="editor-block-settings-menu__control block-editor-block-settings-menu__control"
onClick={ onInsertAfter }
onClick={ () => {
onClose();
onInsertAfter();
} }
icon="insert-after"
shortcut={ shortcuts.insertAfter.display }
>
Expand Down

0 comments on commit 957e0c8

Please sign in to comment.