Remove stateReducer memoization. Add isPressEnterToChange knob for In…

…put stories
WordPress · May 14, 2020 · 920060b · 920060b
1 parent db4f125
commit 920060b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/packages/components/src/input-control/state.js b/packages/components/src/input-control/state.js
@@ -5,7 +5,7 @@ import { flattenDeep } from 'lodash';
 /**
  * WordPress dependencies
  */
-import { useMemo, useReducer } from '@wordpress/element';
+import { useReducer } from '@wordpress/element';
 
 const initialStateReducer = ( state ) => state;
 
@@ -179,13 +179,9 @@ export function useInputControlStateReducer(
 	initialState = initialInputControlState
 ) {
 	const combinedReducers = combineStateReducers( stateReducer );
-	const reducer = useMemo(
-		() => inputControlStateReducer( combinedReducers ),
-		[]
-	);
 
 	const [ state, dispatch ] = useReducer(
-		reducer,
+		inputControlStateReducer( combinedReducers ),
 		mergeInitialState( initialState )
 	);
 

diff --git a/packages/components/src/input-control/stories/index.js b/packages/components/src/input-control/stories/index.js
@@ -25,6 +25,7 @@ function Example() {
 		disabled: boolean( 'disabled', false ),
 		hideLabelFromVision: boolean( 'hideLabelFromVision', false ),
 		isFloatingLabel: boolean( 'isFloatingLabel', false ),
+		isPressEnterToChange: boolean( 'isPressEnterToChange', false ),
 		label: text( 'label', 'Value' ),
 		placeholder: text( 'placeholder', 'Placeholder' ),
 		size: select(

diff --git a/packages/components/src/number-control/stories/index.js b/packages/components/src/number-control/stories/index.js
@@ -25,6 +25,7 @@ function Example() {
 		disabled: boolean( 'disabled', false ),
 		hideLabelFromVision: boolean( 'hideLabelFromVision', false ),
 		isFloatingLabel: boolean( 'isFloatingLabel', false ),
+		isPressEnterToChange: boolean( 'isPressEnterToChange', false ),
 		isShiftStepEnabled: boolean( 'isShiftStepEnabled', true ),
 		label: text( 'label', 'Number' ),
 		min: number( 'min', 0 ),

diff --git a/packages/components/src/unit-control/stories/index.js b/packages/components/src/unit-control/stories/index.js
@@ -26,6 +26,7 @@ function Example() {
 		disableUnits: boolean( 'disableUnits', false ),
 		hideLabelFromVision: boolean( 'hideLabelFromVision', false ),
 		isFloatingLabel: boolean( 'isFloatingLabel', false ),
+		isPressEnterToChange: boolean( 'isPressEnterToChange', true ),
 		isShiftStepEnabled: boolean( 'isShiftStepEnabled', true ),
 		isUnitSelectTabbable: boolean( 'isUnitSelectTabbable', true ),
 		label: text( 'label', 'Value' ),