Skip to content

Commit

Permalink
Blocks: Disable Grouping when block removal is locked (#39541)
Browse files Browse the repository at this point in the history
* Blocks: Disable Grouping when block removal is locked
* Use selector in slot
  • Loading branch information
Mamaduka authored Mar 17, 2022
1 parent 3b82c06 commit 7d39bec
Showing 1 changed file with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ import { store as blockEditorStore } from '../../store';
const { Fill, Slot } = createSlotFill( 'BlockSettingsMenuControls' );

const BlockSettingsMenuControlsSlot = ( { fillProps, clientIds = null } ) => {
const { selectedBlocks, selectedClientIds } = useSelect(
const { selectedBlocks, selectedClientIds, canRemove } = useSelect(
( select ) => {
const { getBlocksByClientId, getSelectedBlockClientIds } = select(
blockEditorStore
);
const {
getBlocksByClientId,
getSelectedBlockClientIds,
canRemoveBlocks,
} = select( blockEditorStore );
const ids =
clientIds !== null ? clientIds : getSelectedBlockClientIds();
return {
Expand All @@ -39,6 +41,7 @@ const BlockSettingsMenuControlsSlot = ( { fillProps, clientIds = null } ) => {
( block ) => block.name
),
selectedClientIds: ids,
canRemove: canRemoveBlocks( ids ),
};
},
[ clientIds ]
Expand All @@ -50,7 +53,8 @@ const BlockSettingsMenuControlsSlot = ( { fillProps, clientIds = null } ) => {
// and pass this props down to ConvertToGroupButton.
const convertToGroupButtonProps = useConvertToGroupButtonProps();
const { isGroupable, isUngroupable } = convertToGroupButtonProps;
const showConvertToGroupButton = isGroupable || isUngroupable;
const showConvertToGroupButton =
( isGroupable || isUngroupable ) && canRemove;

return (
<Slot fillProps={ { ...fillProps, selectedBlocks, selectedClientIds } }>
Expand Down

0 comments on commit 7d39bec

Please sign in to comment.