Revert adding a new value of none (or minimal) to the allowed val…

…ues for the `size` prop
WordPress · Jun 16, 2021 · 7695b97 · 7695b97
1 parent 0032632
commit 7695b97
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 14 deletions.
diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -4,7 +4,6 @@
 
 ### New Feature
 
--   Add `minimal` as one of the possible values for the `size` prop in `Card`, `CardBody`, `CardHeader`, and `CardFooter` ([#32566](https://github.com/WordPress/gutenberg/pull/32566)).
 -   Update the border color used in `CardBody`, `CardHeader`, `CardFooter`, and `CardDivider` to a different shade of gray, in order to match the color used in other components ([#32566](https://github.com/WordPress/gutenberg/pull/32566)).
 
 ### Deprecation

diff --git a/packages/components/src/card/card-body/README.md b/packages/components/src/card/card-body/README.md
@@ -38,4 +38,4 @@ Determines the amount of padding within the component.
 
 - Required: No
 - Default: `medium`
-- Allowed values: `minimal`, `xSmall`, `small`, `medium`, `large`
+- Allowed values: `xSmall`, `small`, `medium`, `large`
diff --git a/packages/components/src/card/card-footer/README.md b/packages/components/src/card/card-footer/README.md
@@ -71,4 +71,4 @@ Determines the amount of padding within the component.
 
 - Required: No
 - Default: `medium`
-- Allowed values: `minimal`, `xSmall`, `small`, `medium`, `large`
+- Allowed values: `xSmall`, `small`, `medium`, `large`
diff --git a/packages/components/src/card/card-header/README.md b/packages/components/src/card/card-header/README.md
@@ -39,4 +39,4 @@ Determines the amount of padding within the component.
 
 - Required: No
 - Default: `medium`
-- Allowed values: `minimal`, `xSmall`, `small`, `medium`, `large`
+- Allowed values: `xSmall`, `small`, `medium`, `large`
diff --git a/packages/components/src/card/card/README.md b/packages/components/src/card/card/README.md
@@ -62,7 +62,7 @@ Determines the amount of padding within the component.
 
 - Required: No
 - Default: `medium`
-- Allowed values: `minimal`, `xSmall`, `small`, `medium`, `large`
+- Allowed values: `xSmall`, `small`, `medium`, `large`
 
 ### Inherited props
 

diff --git a/packages/components/src/card/styles.js b/packages/components/src/card/styles.js
@@ -98,7 +98,6 @@ export const cardPaddings = {
 	xSmall: css`
 		padding: ${ CONFIG.cardPaddingXSmall };
 	`,
-	minimal: '',
 };
 
 export const shady = css`

diff --git a/packages/components/src/card/test/__snapshots__/index.js.snap b/packages/components/src/card/test/__snapshots__/index.js.snap
@@ -97,15 +97,15 @@ Snapshot Diff:
     >
       <div
 -       class="components-flex components-card__header components-card-header css-z1wxd8-Flex-ItemsRow-Header-borderRadius-borderColor-medium css-1mm2cvy-View em57xhy0"
-+       class="components-flex components-card__header components-card-header css-15dwmv7-Flex-ItemsRow-Header-borderRadius-borderColor css-1mm2cvy-View em57xhy0"
++       class="components-flex components-card__header components-card-header css-xx0c0v-Flex-ItemsRow-Header-borderRadius-borderColor-large css-1mm2cvy-View em57xhy0"
         data-wp-c16t="true"
         data-wp-component="CardHeader"
       >
         Header
       </div>
       <div
 -       class="components-scrollable components-card__body components-card-body css-1s8bpb2-Scrollable-scrollableScrollbar-scrollY-Body-borderRadius-medium css-1mm2cvy-View em57xhy0"
-+       class="components-scrollable components-card__body components-card-body css-1h3akp0-Scrollable-scrollableScrollbar-scrollY-Body-borderRadius css-1mm2cvy-View em57xhy0"
++       class="components-scrollable components-card__body components-card-body css-ocisz3-Scrollable-scrollableScrollbar-scrollY-Body-borderRadius-large css-1mm2cvy-View em57xhy0"
         data-wp-c16t="true"
         data-wp-component="CardBody"
       >

diff --git a/packages/components/src/card/test/index.js b/packages/components/src/card/test/index.js
@@ -75,21 +75,21 @@ describe( 'Card', () => {
 
 		it( 'should add different amounts of white space when using the size prop', () => {
 			// The `size` prop has a default value of "medium"
-			const { container: withSize } = render(
+			const { container: withSizeDefault } = render(
 				<Card>
 					<CardHeader>Header</CardHeader>
 					<CardBody>Code is Poetry</CardBody>
 				</Card>
 			);
-			const { container: withSizeMinimal } = render(
-				<Card size="minimal">
+			const { container: withSizeLarge } = render(
+				<Card size="large">
 					<CardHeader>Header</CardHeader>
 					<CardBody>Code is Poetry</CardBody>
 				</Card>
 			);
 
-			expect( withSize.firstChild ).toMatchDiffSnapshot(
-				withSizeMinimal.firstChild
+			expect( withSizeDefault.firstChild ).toMatchDiffSnapshot(
+				withSizeLarge.firstChild
 			);
 		} );
 

diff --git a/packages/components/src/card/types.ts b/packages/components/src/card/types.ts
@@ -9,7 +9,7 @@ import type { CSSProperties } from 'react';
  */
 import type { Props as SurfaceProps } from '../surface/types';
 
-export type SizeOptions = 'xSmall' | 'small' | 'medium' | 'large' | 'minimal';
+export type SizeOptions = 'xSmall' | 'small' | 'medium' | 'large';
 
 type SizeableProps = {
 	/**