Skip to content

Commit

Permalink
Polish library just a teeeeensy bit (#7522)
Browse files Browse the repository at this point in the history
This PR does a few small things:

- It removes the "scroll shadow" that sat at the bottom. This was always created for MacOS hiding scrollbars to indicate more content, but was more an issue before there were collapsible panels. It also broke the physics of the shadow.
- It removes the bottom border on the last collapsible panel. That way it doesn't show a double border with the popover.
- It tweaks the color of the Shared icon to be the same as all other icons, and it positions it so a panel with an icon is no taller than a panel without one.
  • Loading branch information
jasmussen authored Jun 25, 2018
1 parent b299f4f commit 70f7f8d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
6 changes: 2 additions & 4 deletions components/panel/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,8 @@
}

.components-panel__icon {
color: $dark-gray-400;
margin-right: 5px;
position: relative;
top: -2px;
color: $dark-gray-500;
margin: -2px 6px -2px 0;
}

.components-panel__body-toggle-icon {
Expand Down
6 changes: 5 additions & 1 deletion editor/components/inserter/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,17 @@ $block-inserter-search-height: 38px;

@include break-medium {
height: $block-inserter-content-height + $block-inserter-tabs-height;
box-shadow: inset 0 -5px 5px -4px rgba( $dark-gray-900, .1 );
}

// Don't show the top border on the first panel, let the Search border be the border.
.components-panel__body:first-child {
border-top: none;
}

// Don't show the bottom border on the last panel, let hte library itself show the border.
.components-panel__body:last-child {
border-bottom: none;
}
}

.editor-inserter__list {
Expand Down

0 comments on commit 70f7f8d

Please sign in to comment.