Wrapping $attributes['id'] in an isset check to catch undefined indexes

Formatting
WordPress · Oct 27, 2021 · 6f594cc · 6f594cc
1 parent 585fc17
commit 6f594cc
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/block-library/src/image/index.php b/packages/block-library/src/image/index.php
@@ -13,9 +13,9 @@
  * @return string            Returns the block content with the data-id attribute added.
  */
 function render_block_core_image( $attributes, $content ) {
-	if ( $attributes['id'] ) {
+	if ( isset( $attributes['id'] ) ) {
 		// Add the data-id="$id" attribute to the img element to retain backwards compatibility.
-		$data_id_attribute  = 'data-id="' . esc_attr( $attributes['id'] ) . '"';
+		$data_id_attribute = 'data-id="' . esc_attr( $attributes['id'] ) . '"';
 		if ( ! strpos( $content, $data_id_attribute ) ) {
 			$content = str_replace( '<img', '<img ' . $data_id_attribute . ' ', $content );
 		}