Fix unexpected autosave for published posts (#27942)

WordPress · Jan 4, 2021 · 6ab4d7a · 6ab4d7a
1 parent dc52d16
commit 6ab4d7a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/packages/editor/src/components/autosave-monitor/index.js b/packages/editor/src/components/autosave-monitor/index.js
@@ -14,7 +14,7 @@ import { withSelect, withDispatch } from '@wordpress/data';
  *
  * There are two caveats:
  * * If `props.isAutosaveable` happens to be false at a time of checking for changes, the check is retried every second.
- * * The timer may be disabled by setting `props.disableIntervalChecks` to `false`. In that mode, any change will immediately trigger `props.autosave()`.
+ * * The timer may be disabled by setting `props.disableIntervalChecks` to `true`. In that mode, any change will immediately trigger `props.autosave()`.
  */
 export class AutosaveMonitor extends Component {
 	constructor( props ) {
@@ -29,15 +29,14 @@ export class AutosaveMonitor extends Component {
 	}
 
 	componentDidUpdate( prevProps ) {
-		if (
-			this.props.disableIntervalChecks &&
-			this.props.editsReference !== prevProps.editsReference
-		) {
-			this.props.autosave();
+		if ( this.props.disableIntervalChecks ) {
+			if ( this.props.editsReference !== prevProps.editsReference ) {
+				this.props.autosave();
+			}
 			return;
 		}
 
-		if ( ! this.props.isDirty && prevProps.isDirty ) {
+		if ( ! this.props.isDirty ) {
 			this.needsAutosave = false;
 			return;
 		}

diff --git a/packages/editor/src/components/autosave-monitor/test/index.js b/packages/editor/src/components/autosave-monitor/test/index.js
@@ -17,7 +17,7 @@ describe( 'AutosaveMonitor', () => {
 			AutosaveMonitor.prototype,
 			'setAutosaveTimer'
 		);
-		wrapper = shallow( <AutosaveMonitor />, {
+		wrapper = shallow( <AutosaveMonitor isDirty />, {
 			lifecycleExperimental: true,
 		} );
 	} );
@@ -36,7 +36,7 @@ describe( 'AutosaveMonitor', () => {
 	} );
 
 	describe( '#componentDidUpdate()', () => {
-		it( 'should set needsAutosave=true when editReference changes and other props stay the same (1)', () => {
+		it( 'should set needsAutosave=true when editReference changes', () => {
 			expect( wrapper.instance().needsAutosave ).toBe( false );
 			wrapper.setProps( {
 				editsReference: [],