Use Colors: Only re-detect background color when color attributes cha…

…nge.
WordPress · Nov 4, 2019 · 62392a3 · 62392a3
1 parent 04f656d
commit 62392a3
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/block-editor/src/components/colors/use-colors.js b/packages/block-editor/src/components/colors/use-colors.js
@@ -199,7 +199,15 @@ export default function __experimentalUseColors(
 				detectedBackgroundColorRef.current = backgroundColor;
 				return { backgroundColor };
 			} )( () => <></> ),
-		[ attributes ]
+		[
+			colorConfigs.reduce(
+				( acc, colorConfig ) =>
+					`${ acc } | ${ attributes[ colorConfig.name ] } | ${
+						attributes[ camelCase( `custom ${ colorConfig.name }` ) ]
+					}`,
+				''
+			),
+		]
 	);
 
 	return useMemo( () => {
@@ -272,5 +280,5 @@ export default function __experimentalUseColors(
 			),
 			BackgroundColorDetector,
 		};
-	}, [ attributes, setAttributes, ...deps ] );
+	}, [ attributes, setAttributes, detectedBackgroundColorRef.current, ...deps ] );
 }