Skip to content

Commit

Permalink
remove sidebar from post-editor, move out component from block-editor…
Browse files Browse the repository at this point in the history
… to site-editor package
  • Loading branch information
gwwar committed Feb 11, 2022
1 parent ddf4220 commit 615b3f3
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 19 deletions.
1 change: 0 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions packages/block-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@

- Removed unused `@wordpress/block-serialization-default-parser`, `css-mediaquery`, `memize` and `redux-multi` dependencies ([#38388](https://github.com/WordPress/gutenberg/pull/38388)).

### New Features

- Added new `__experimentalNavigationInspector` component and `__experimentalGetGlobalBlocksByName` selector. [#38600](https://github.com/WordPress/gutenberg/pull/38600)

## 8.1.0 (2022-01-27)

## 8.0.0 (2021-11-07)
Expand Down
1 change: 0 additions & 1 deletion packages/block-editor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"@wordpress/blocks": "file:../blocks",
"@wordpress/components": "file:../components",
"@wordpress/compose": "file:../compose",
"@wordpress/core-data": "file:../core-data",
"@wordpress/data": "file:../data",
"@wordpress/deprecated": "file:../deprecated",
"@wordpress/dom": "file:../dom",
Expand Down
1 change: 0 additions & 1 deletion packages/block-editor/src/components/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ export { default as __unstableInserterMenuExtension } from './inserter-menu-exte
export { default as __experimentalPreviewOptions } from './preview-options';
export { default as __experimentalUseResizeCanvas } from './use-resize-canvas';
export { default as BlockInspector } from './block-inspector';
export { default as __experimentalNavigationInspector } from './navigation-inspector';
export { default as BlockList } from './block-list';
export { useBlockProps } from './block-list/use-block-props';
export { LayoutStyle as __experimentalLayoutStyle } from './block-list/layout';
Expand Down
1 change: 0 additions & 1 deletion packages/block-editor/src/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@

@import "./components/block-toolbar/style.scss";
@import "./components/inserter/style.scss";
@import "./components/navigation-inspector/style.scss";
@import "./components/preview-options/style.scss";

@include wordpress-admin-schemes();
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
import { FlexBlock, Flex } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { navigation } from '@wordpress/icons';
import { __experimentalNavigationInspector as NavigationInspector } from '@wordpress/block-editor';

/**
* Internal dependencies
*/
import DefaultSidebar from '../default-sidebar';
import NavigationInspector from './navigation-inspector';

export default function NavigationMenuSidebar() {
return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,19 @@
import { useSelect } from '@wordpress/data';
import { useState, useEffect } from '@wordpress/element';
import { SelectControl } from '@wordpress/components';
import {
__experimentalListView as ListView,
store as blockEditorStore,
} from '@wordpress/block-editor';

/**
* Internal dependencies
*/
import NavigationOption from './navigation-option';
import { store as blockEditorStore } from '../../store';
import ListView from '../list-view';

const EMPTY_BLOCKS = [];

export default function __experimentalNavigationInspector() {
export default function NavigationInspector() {
const {
selectedClientId,
selectedNavigationId,
Expand Down Expand Up @@ -69,7 +71,7 @@ export default function __experimentalNavigationInspector() {
const showListView = ! isLoading && hasMenus;

return (
<div className="block-editor-navigation-inspector">
<div className="edit-site-navigation-inspector">
{ showSelectControl && (
<SelectControl
value={ menu || firstNavigationId }
Expand All @@ -89,9 +91,9 @@ export default function __experimentalNavigationInspector() {
) }
{ isLoading && (
<>
<div className="block-editor-navigation-inspector__placeholder" />
<div className="block-editor-navigation-inspector__placeholder is-child" />
<div className="block-editor-navigation-inspector__placeholder is-child" />
<div className="edit-site-navigation-inspector__placeholder" />
<div className="edit-site-navigation-inspector__placeholder is-child" />
<div className="edit-site-navigation-inspector__placeholder is-child" />
</>
) }
{ showListView && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@
}
}

.block-editor-navigation-inspector {
.edit-site-navigation-inspector {
padding: $grid-unit-20;
}

.block-editor-navigation-inspector__placeholder {
.edit-site-navigation-inspector__placeholder {
padding: $grid-unit-10;
margin: $grid-unit-10;
background-color: $gray-100;
animation: loadingpulse 1s linear infinite;
animation-delay: 0.5s; // avoid animating for fast network responses
}

.block-editor-navigation-inspector__placeholder.is-child {
.edit-site-navigation-inspector__placeholder.is-child {
margin-left: $grid-unit-30;
width: 50%;
}
1 change: 1 addition & 0 deletions packages/edit-site/src/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
@import "./components/add-new-template/style.scss";
@import "./components/sidebar/style.scss";
@import "./components/sidebar/settings-header/style.scss";
@import "./components/sidebar/navigation-menu-sidebar/style.scss";
@import "./components/sidebar/template-card/style.scss";
@import "./components/editor/style.scss";
@import "./components/template-details/style.scss";
Expand Down

0 comments on commit 615b3f3

Please sign in to comment.