Skip to content

Commit

Permalink
Add repository.directory linting rule (fixes #13947) (#14200)
Browse files Browse the repository at this point in the history
* Add repository.directory rule to npm-package-json-lint-config (fix #13947)

* Fix lock file (props @aduth)

* Fix rule, update changelogs

* Add PR reference

* Add directory field to packages/docgen

* Apply changes suggested by @ntwb

* Update CHANGELOG.md
  • Loading branch information
Ned Zimmerman authored and youknowriad committed Mar 6, 2019
1 parent 22d3dd0 commit 5f4bd17
Show file tree
Hide file tree
Showing 8 changed files with 121 additions and 73 deletions.
176 changes: 107 additions & 69 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@
}
],
"require-publishConfig": "error",
"require-repository-directory": "error",
"valid-values-author": [
"error",
[
Expand Down
3 changes: 2 additions & 1 deletion packages/docgen/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"homepage": "https://github.com/WordPress/gutenberg/tree/master/packages/docgen/README.md",
"repository": {
"type": "git",
"url": "git+https://github.com/WordPress/gutenberg.git"
"url": "git+https://github.com/WordPress/gutenberg.git",
"directory": "packages/docgen"
},
"bugs": {
"url": "https://github.com/WordPress/gutenberg/issues"
Expand Down
8 changes: 7 additions & 1 deletion packages/npm-package-json-lint-config/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
## v1.1.3 (2018-09-05)
## 1.1.4 (Unreleased)

### Internal

- Updated `npm-package-json-lint` dependency [#14200](https://github.com/WordPress/gutenberg/pull/14200)

## 1.1.3 (2018-09-05)

### Bug Fix

Expand Down
1 change: 1 addition & 0 deletions packages/npm-package-json-lint-config/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ const defaultConfig = {
'require-private': 'off',
'require-publishConfig': 'off',
'require-repository': 'error',
'require-repository-directory': 'off',
'require-scripts': 'off',
'require-version': 'error',
'scripts-type': 'error',
Expand Down
2 changes: 1 addition & 1 deletion packages/npm-package-json-lint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"main": "index.js",
"peerDependencies": {
"npm-package-json-lint": ">=3.3.1"
"npm-package-json-lint": ">=3.6.0"
},
"publishConfig": {
"access": "public"
Expand Down
1 change: 1 addition & 0 deletions packages/scripts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- Added support for `build` script ([#12837](https://github.com/WordPress/gutenberg/pull/12837))
- Added support for `start` script ([#12837](https://github.com/WordPress/gutenberg/pull/12837))
- Updated `npm-package-json-lint` dependency [#14200](https://github.com/WordPress/gutenberg/pull/14200)

### Bug Fix

Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"eslint": "^5.12.1",
"jest": "^24.1.0",
"jest-puppeteer": "^4.0.0",
"npm-package-json-lint": "^3.3.1",
"npm-package-json-lint": "^3.6.0",
"puppeteer": "1.6.1",
"read-pkg-up": "^1.0.1",
"resolve-bin": "^0.4.0",
Expand Down

0 comments on commit 5f4bd17

Please sign in to comment.