Skip to content

Commit

Permalink
Site Logo: Fix loader alignment issue (#64919)
Browse files Browse the repository at this point in the history
* Fix loader alignment issue in site logo block

* Update isLoading check

Co-authored-by: akasunil <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: jasmussen <[email protected]>
  • Loading branch information
4 people authored Sep 3, 2024
1 parent 9f4f79a commit 5109d5b
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions packages/block-library/src/site-logo/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -654,16 +654,17 @@ export default function LogoEdit( {
{ controls }
{ mediaInspectorPanel }
{ ( !! logoUrl || !! temporaryURL ) && logoImage }
{ ! temporaryURL && ! logoUrl && ! canUserEdit && (
<Placeholder className="site-logo_placeholder">
{ !! isLoading && (
{ ( isLoading ||
( ! temporaryURL && ! logoUrl && ! canUserEdit ) ) && (
<Placeholder className="site-logo_placeholder" withIllustration>
{ isLoading && (
<span className="components-placeholder__preview">
<Spinner />
</span>
) }
</Placeholder>
) }
{ ! temporaryURL && ! logoUrl && canUserEdit && (
{ ! isLoading && ! temporaryURL && ! logoUrl && canUserEdit && (
<MediaPlaceholder
onSelect={ onInitialSelectLogo }
accept={ ACCEPT_MEDIA_STRING }
Expand Down

0 comments on commit 5109d5b

Please sign in to comment.