Skip to content

Commit

Permalink
RadioGroup: Fix arrow key navigation in RTL (#66202)
Browse files Browse the repository at this point in the history 
Co-authored-by: ciampo <[email protected]>
Co-authored-by: tyxla <[email protected]>
  • Loading branch information
@ciampo @tyxla
3 people authored Oct 17, 2024
1 parent 99eae66 commit 4f405ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- `Tabs`: fix indicator animation ([#66198](https://github.com/WordPress/gutenberg/pull/66198)).
- `ColorPalette`: prevent overflow of custom color button background ([#66152](https://github.com/WordPress/gutenberg/pull/66152)).
- `RadioGroup`: Fix arrow key navigation in RTL ([#66202](https://github.com/WordPress/gutenberg/pull/66202)).
- `Tabs` and `TabPanel`: Fix arrow key navigation in RTL ([#66201](https://github.com/WordPress/gutenberg/pull/66201)).

### Enhancements
Expand Down
2 changes: 2 additions & 0 deletions packages/components/src/radio-group/index.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import * as Ariakit from '@ariakit/react';
* WordPress dependencies
*/
import { useMemo, forwardRef } from '@wordpress/element';
import { isRTL } from '@wordpress/i18n';

/**
* Internal dependencies
Expand Down Expand Up @@ -34,6 +35,7 @@ function UnforwardedRadioGroup(
setValue: ( newValue ) => {
onChange?.( newValue ?? undefined );
},
rtl: isRTL(),
} );

const contextValue = useMemo(
Expand Down

1 comment on commit 4f405ac

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 4f405ac.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11388694434
📝 Reported issues:

Please sign in to comment.