Skip to content

Commit

Permalink
[RNMobile] Tweaks to Badge Component's Styling (#32865)
Browse files Browse the repository at this point in the history
* Update background colour

The background colour of the badge component is updated to a darker gray colour with this commit (from $gray-70 to $gray-dark). This matches the colour of the edit button, which is displayed to the upper right of the image block when selected.

* Update margin and padding

The component's margin and padding is updated with this commit to match the original designs for the badge component.

* Update CHANGELOG.md

* Revert margin change

It was agreed that the original margin of 8px works better for the badge, as it is more vertically aligned with the image block's edit badge. See: #32865 (review)
  • Loading branch information
SiobhyB authored Jun 24, 2021
1 parent cde38ac commit 32ca6e4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/components/src/mobile/badge/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
}

.badge {
padding: 10px;
padding: 3px 6px;
margin: 8px;
color: #fff;
border-radius: 3px;
background-color: $gray-70;
border-color: $gray-70;
background-color: $gray-dark;
border-color: $gray-dark;
}
2 changes: 2 additions & 0 deletions packages/react-native-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ For each user feature we should also add a importance categorization label to i
## 1.55.2
- [**] Fix incorrect block insertion point after blurring the post title field. [#32831]

- [*] Tweaks to the badge component's styling, including change of background color and reduced padding. [#32865]

## 1.55.1
- [*] Fix: RNMobile borderRadius value setting [#32717]
- [*] Improve unsupported block message for reusable block [#32618]
Expand Down

0 comments on commit 32ca6e4

Please sign in to comment.