Replaced beforeDestroy With afterDestroy

WordPress · May 18, 2023 · 318b5cf · 318b5cf
1 parent 9c3a0f7
commit 318b5cf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/env/CHANGELOG.md b/packages/env/CHANGELOG.md
@@ -8,7 +8,7 @@
 
 ### New feature
 
--   Add `afterStart`, `afterClean`, and `beforeDestroy` lifecycle scripts to a new `lifecycleScripts` key in `.wp-env.json`.
+-   Add `afterStart`, `afterClean`, and `afterDestroy` lifecycle scripts to a new `lifecycleScripts` key in `.wp-env.json`.
 -   Add a series of `WP_ENV_LIFECYCLE_SCRIPT_` environment variables for the various lifecycle scripts.
 
 ### Enhancement

diff --git a/packages/env/README.md b/packages/env/README.md
@@ -569,7 +569,7 @@ build won't break on subsequent executions.
 
 * `afterStart`: Runs after `wp-env start` has finished setting up the environment.
 * `afterClean`: Runs after `wp-env clean` has finished cleaning the environment.
-* `beforeDestroy`: Runs before `wp-env destroy` begins destroying anything.
+* `afterDestroy`: Runs after `wp-env destroy` has destroyed the environment.
 
 ## Examples
 

diff --git a/packages/env/lib/commands/destroy.js b/packages/env/lib/commands/destroy.js
@@ -57,10 +57,6 @@ module.exports = async function destroy( { spinner, scripts, debug } ) {
 		return;
 	}
 
-	if ( scripts ) {
-		await executeLifecycleScript( 'beforeDestroy', config, spinner );
-	}
-
 	spinner.text = 'Removing docker images, volumes, and networks.';
 
 	await dockerCompose.down( {
@@ -76,5 +72,9 @@ module.exports = async function destroy( { spinner, scripts, debug } ) {
 	await new Promise( ( resolve ) => setTimeout( resolve, 10000 ) );
 	await rimraf( config.workDirectoryPath );
 
+	if ( scripts ) {
+		await executeLifecycleScript( 'afterDestroy', config, spinner );
+	}
+
 	spinner.text = 'Removed WordPress environment.';
 };