Skip to content

Commit

Permalink
Clarify the default throwOnError behavior
Browse files Browse the repository at this point in the history
  • Loading branch information
adamziel committed Mar 11, 2022
1 parent 7ae5525 commit 291d425
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions docs/reference-guides/data/data-core.md
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ _Parameters_
- _query_ `?Object`: Special query parameters for the DELETE API call.
- _options_ `[Object]`: Delete options.
- _options.\_\_unstableFetch_ `[Function]`: Internal use only. Function to call instead of `apiFetch()`. Must return a promise.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions. Defaults to false.

### editEntityRecord

Expand Down Expand Up @@ -704,7 +704,7 @@ _Parameters_
- _options_ `Object`: Saving options.
- _options.isAutosave_ `[boolean]`: Whether this is an autosave.
- _options.\_\_unstableFetch_ `[Function]`: Internal use only. Function to call instead of `apiFetch()`. Must return a promise.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions. Defaults to false.

### undo

Expand Down
4 changes: 2 additions & 2 deletions packages/core-data/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ _Parameters_
- _query_ `?Object`: Special query parameters for the DELETE API call.
- _options_ `[Object]`: Delete options.
- _options.\_\_unstableFetch_ `[Function]`: Internal use only. Function to call instead of `apiFetch()`. Must return a promise.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions. Defaults to false.

### editEntityRecord

Expand Down Expand Up @@ -238,7 +238,7 @@ _Parameters_
- _options_ `Object`: Saving options.
- _options.isAutosave_ `[boolean]`: Whether this is an autosave.
- _options.\_\_unstableFetch_ `[Function]`: Internal use only. Function to call instead of `apiFetch()`. Must return a promise.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions.
- _options.throwOnError_ `[boolean]`: If false, this action suppresses all the exceptions. Defaults to false.

### undo

Expand Down
4 changes: 2 additions & 2 deletions packages/core-data/src/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ export function receiveEmbedPreview( url, preview ) {
* call instead of `apiFetch()`.
* Must return a promise.
* @param {boolean} [options.throwOnError=false] If false, this action suppresses all
* the exceptions.
* the exceptions. Defaults to false.
*/
export const deleteEntityRecord = (
kind,
Expand Down Expand Up @@ -401,7 +401,7 @@ export function __unstableCreateUndoLevel() {
* call instead of `apiFetch()`.
* Must return a promise.
* @param {boolean} [options.throwOnError=false] If false, this action suppresses all
* the exceptions.
* the exceptions. Defaults to false.
*/
export const saveEntityRecord = (
kind,
Expand Down

0 comments on commit 291d425

Please sign in to comment.