Add aria-checked

WordPress · Nov 30, 2023 · 250baba · 250baba
1 parent 9c40cbc
commit 250baba
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/edit-site/src/components/dataviews/filter-summary.js b/packages/edit-site/src/components/dataviews/filter-summary.js
@@ -99,6 +99,9 @@ export default function FilterSummary( { filter, view, onChangeView } ) {
 							<DropdownMenuItem
 								key={ element.value }
 								role="menuitemradio"
+								aria-checked={
+									activeElement?.value === element.value
+								}
 								prefix={
 									activeElement?.value === element.value && (
 										<Icon icon={ check } />
@@ -144,6 +147,9 @@ export default function FilterSummary( { filter, view, onChangeView } ) {
 						<DropdownMenuItem
 							key="in-filter"
 							role="menuitemradio"
+							aria-checked={
+								filterInView?.operator === OPERATOR_IN
+							}
 							prefix={
 								filterInView?.operator === OPERATOR_IN && (
 									<Icon icon={ check } />
@@ -171,6 +177,9 @@ export default function FilterSummary( { filter, view, onChangeView } ) {
 						<DropdownMenuItem
 							key="not-in-filter"
 							role="menuitemradio"
+							aria-checked={
+								filterInView?.operator === OPERATOR_NOT_IN
+							}
 							prefix={
 								filterInView?.operator === OPERATOR_NOT_IN && (
 									<Icon icon={ check } />

diff --git a/packages/edit-site/src/components/dataviews/view-list.js b/packages/edit-site/src/components/dataviews/view-list.js
@@ -202,6 +202,7 @@ function HeaderMenu( { dataView, header } ) {
 											<DropdownMenuItem
 												key={ element.value }
 												role="menuitemradio"
+												aria-checked={ isActive }
 												prefix={
 													isActive && (
 														<Icon icon={ check } />
@@ -237,6 +238,10 @@ function HeaderMenu( { dataView, header } ) {
 										<DropdownMenuItem
 											key="in-filter"
 											role="menuitemradio"
+											aria-checked={
+												filterInView?.operator ===
+												OPERATOR_IN
+											}
 											prefix={
 												filterInView?.operator ===
 													OPERATOR_IN && (
@@ -260,6 +265,10 @@ function HeaderMenu( { dataView, header } ) {
 										<DropdownMenuItem
 											key="not-in-filter"
 											role="menuitemradio"
+											aria-checked={
+												filterInView?.operator ===
+												OPERATOR_NOT_IN
+											}
 											prefix={
 												filterInView?.operator ===
 													OPERATOR_NOT_IN && (