Makes appenders visible only for the current selection (#19598)

* makes appenders visible only for the current selection * adds smaller footprint to appenders in navigation, only shows them if item has descendants * align appender to level of the menu item, remove useless CSS
WordPress · Jan 21, 2020 · 24c0e60 · 24c0e60
1 parent cd309db
commit 24c0e60
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -197,7 +197,7 @@ function NavigationLinkEdit( {
 				</div>
 				<InnerBlocks
 					allowedBlocks={ [ 'core/navigation-link' ] }
-					renderAppender={ hasDescendants ? InnerBlocks.ButtonBlockAppender : false }
+					renderAppender={ ( hasDescendants && isSelected ) ? InnerBlocks.DefaultAppender : false }
 				/>
 			</div>
 		</Fragment>

diff --git a/packages/block-library/src/navigation/editor.scss b/packages/block-library/src/navigation/editor.scss
@@ -62,9 +62,15 @@ $navigation-item-height: 46px;
 	// Polish the Appender.
 	.wp-block-navigation .block-list-appender {
 		margin: 0;
+		width: 28px;
+		height: 28px;
+		margin-top: $grid-size-small;
+		margin-left: $grid-size + $block-side-ui-clearance;
 
 		.block-editor-button-block-appender {
 			padding: $grid-size;
+			padding-bottom: $grid-size-small;
+			padding-top: $grid-size-small;
 			outline: none;
 			background: none;
 		}

diff --git a/packages/block-library/src/navigation/style.scss b/packages/block-library/src/navigation/style.scss
@@ -1,5 +1,4 @@
 .wp-block-navigation {
-
 	& > ul {
 		display: block;
 		list-style: none;